search

Crazy-Marvin / VacationDays

Know when you are free.
https://crazymarvin.com/vacation-days/
Apache License 2.0
37 stars 9 forks source link

Missing strings #22

Closed comradekingu closed 2 years ago

comradekingu commented 2 years ago

@CrazyMarvin Added screenshots https://hosted.weblate.org/screenshots/vacation-days/vacation-days/ but a lot of those strings aren't in https://hosted.weblate.org/zen/vacation-days/vacation-days/en/?q=

Only the ones in https://github.com/Crazy-Marvin/VacationDays/blob/development/app/src/main/res/values/strings.xml are shown, and everything in https://github.com/Crazy-Marvin/VacationDays/blob/aa33f7df3605b69a1d1c6638abd561311cdcbef2/app/src/main/res/layout/activity_settings.xml is missing.

Can those be added to the regular strings.xml?

CrazyMarvin commented 2 years ago

I will ask the Weblate support to have a look at the configuration.

comradekingu commented 2 years ago

It is no surprise it doesn't work when there is only "app/src/main/res/values-*/strings.txt" in https://hosted.weblate.org/settings/vacation-days/vacation-days/#files

I am thinking Android won't pick up app/src/main/res/layout/nb_NO/activity_settings.xml etc.

If the content and pointers to activity_settings.xml was in strings.xml the setup would work.

CrazyMarvin commented 2 years ago

We will put all strings into /app/src/main/res/values/strings.xml. This should fix this issue. Thanks for reporting! 👍

CrazyMarvin commented 2 years ago

We will put all strings into /app/src/main/res/values/strings.xml. This should fix this issue. Thanks for reporting! 👍

Done. 👌