CrazyDude1994 / android-taranis-smartport-telemetry

This android application let you view and record your taranis telemetry data in realtime.

https://play.google.com/store/apps/details?id=crazydude.com.telemetry

143 stars 42 forks source link

fixed: crash when trying to move sensor #108

Closed RomanLut closed 3 years ago

RomanLut commented 3 years ago

IS: Trying to move last sensor in sensor configuration screen (lasndscape, list is scrolled bottom) crashes application.

CrazyDude1994 commented 3 years ago

I thought it was fixed in the https://github.com/CrazyDude1994/android-taranis-smartport-telemetry/pull/95 ?

RomanLut commented 3 years ago

95 did not fixed all cases.

If list is scrolled to the bottom in landscape mode on small screen, both findViewByPosition(1).findViewById(R.id.move) and findViewByPosition(2).findViewById(R.id.move) return null because these list elements are out of screen and might be destroyed. We can accept two nulls but should not crash.