search

CrazyDude1994 / android-taranis-smartport-telemetry

This android application let you view and record your taranis telemetry data in realtime.
https://play.google.com/store/apps/details?id=crazydude.com.telemetry
143 stars 42 forks source link

Fixed app crash when replaying a logfile and changing phone orientation #121

Closed mrclgl closed 3 years ago

mrclgl commented 3 years ago

When replaying a logfile (using the FileAPI) the App crashes when you rotate the Phone. The App reloads in the new orientation and tries to load the logfile using the replayFileString. But if the storageAPI isnt used the replayFileString is set to the logfile NAME, without the extension (".log") which causes the App to crash when loading the file (FileNotFoundException: No such file or directory).

TelemetryViewer_RotationError TelemetryViewer_RotationError_Fix

CrazyDude1994 commented 3 years ago

Right now i'm working on the big code rewrite, and as far as I remember, I fixed it already. In any case I'll leave this open for now

RomanLut commented 3 years ago

FYI this crash occurs in app built from master branch currently.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

CrazyDude1994 commented 3 years ago

@Check2016 hi. I'm going to merge my changes, which already fixes this issue. https://github.com/CrazyDude1994/android-taranis-smartport-telemetry/pull/128 Thanks for the contributing tho!