CrazyDude1994 / android-taranis-smartport-telemetry

This android application let you view and record your taranis telemetry data in realtime.
https://play.google.com/store/apps/details?id=crazydude.com.telemetry
143 stars 42 forks source link

Merge mavlink failsafe mode decoding #136

Closed RomanLut closed 2 years ago

RomanLut commented 2 years ago

It is better to show nothing instead of incorrect information.

1) Under failsafe state, INAV sends customMode = PLANE_MODE_ENUM_END / COPTER_MODE_ENUM_END. Currently it is not handled at all, showing "Armed | Acro | Failsafe", which is not true. It is better to show just "Armed | Failsafe" untill correct mode is available ( F.e. "Armed | RTH | Failsafe" ).

2) INAV sends custom mode = AUTO for Mission and for Landing. It is possible to distinguish between Mission and Landing inspecting MAV_STATE_CRITICAL flag. BUT it seems that qczek LRS is modifying mavlink messages and sets MAV_STATE_CRITICAL flag, which causes last mode (Mission) to be decoded as Landing. This is bad experience for the user, it is better to show nothing for the case customMode = AUTO & Failsafe because it is not possible to realibly distingush correct mode.

image

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.4% 1.4% Duplication