CrazyDude1994 / android-taranis-smartport-telemetry

This android application let you view and record your taranis telemetry data in realtime.
https://play.google.com/store/apps/details?id=crazydude.com.telemetry
145 stars 43 forks source link

Dev.crsf packet handling.andwright #52

Closed andwright closed 4 years ago

andwright commented 4 years ago

Hi @CrazyDude1994, version 17b3 code 22 doesn't appear to load the whole of the log file (still only have logs created with version 17b2). In the debugger it looks like the input buffer is growing massive and, as packets are processed from the front of the queue and inserted onto the end, not all the packets are processed.

Here's all the logs I have do date:

2020-01-03 12-38-19.log 2020-01-06 12-48-10.log 2020-01-10 12-34-02.log 2020-01-21 13-04-51.log 2020-02-06 12-57-51.log 2020-02-06 13-06-09.log 2020-02-06 12-49-53.log 2020-02-06 12-41-18.log 2020-01-10 12-52-34.log 2020-01-21 12-44-23.log 2020-01-21 13-15-07.log 2020-02-05 22-20-41.log

I "think" as far as I can tell, the version in this pull request works. It seems to work with all the above logs. Anyway, I'm happy to carry on with any testing.

andwright commented 4 years ago

Yeah sure - Superfluous white space removed. Also swapped the order of a couple of the checks to improve the code slightly.