CrazyPython
commented
3 years ago The hover effect is nice. It's a good improvement, that if refined, could turn into an improvement:
It would be easier if the changes here were split up into multiple ones (background color, hover effect, and markup changes) so they can be reviewed independently. That would mean making 3 branches on your fork of this repo, and sending 3 pull requests.
And also at the places of heading tags i replaced those with a paragraph tag so that styling of those will be easy.
You can select by tag names:
h1 {
}
h2 {
}
h3 {
}If I wanted to make it possible to style headers independently in each section, I would change the "div" tag to a "footer" semantic markup tag, and maybe do this:
footer > h3 {
}I'm not sure of the utility of your changes.
Hi there! I added a background colour and made a hovering effect. And also at the places of heading tags i replaced those with a paragraph tag so that styling of those will be easy. fixed issue #2
And also there was a suggestion that instead of making the table and rotating it , you would have made the table like this only. Then it would be very easy for more customization and adding new features.