search

CreateJS / EaselJS

The Easel Javascript library provides a full, hierarchical display list, a core interaction model, and helper classes to make working with the HTML5 Canvas element much easier.
http://createjs.com/
MIT License
8.11k stars 1.97k forks source link

Fix lib/easeljs typo getDataUrl #1049

Closed davidholyko closed 3 years ago

davidholyko commented 3 years ago

Fixes typo in lib/easeljs.js where this.bitmapCache.getDataURL is undefined

davidholyko commented 3 years ago

Hi @danzen, I'm not sure exactly what you mean. Can you explain further? Thanks!

danzen commented 3 years ago

@davidholyko you found the typo in the DisplayObject. There is also the same typo in the Bitmap class if you look for bitmapCache.getDataURL(). So would you like to modify your pull request to update both these. I will then advise that we accept the pull request. (The only reason I ask is that I have not done a pull request yet - I probably will one day - but it would just be easier if I could advise the crew to accept this one and have it fix both parts - plus, it is your find). Thanks - if I don't make sense, tell us to handle it from here and we can. Cheers - and thanks for pointing it out - sorry for the delay.

davidholyko commented 3 years ago

@danzen I did not find bitmapCache.getDataURL() in the Bitmap class file but I did find getDataURL in BitmapCache class

https://github.com/CreateJS/EaselJS/blob/master/src/easeljs/filters/BitmapCache.js#L521

davidholyko commented 3 years ago

@danzen Are there any additional steps that I can take to get this merged?

danzen commented 3 years ago

Hi @davidholyko - thanks for the reminder. Just got access to actually merge ;-) and working through setting up the testing environment here. If you could confirm that the merge is working for you, that would be helpful. Cheers!