CreateJS / EaselJS

The Easel Javascript library provides a full, hierarchical display list, a core interaction model, and helper classes to make working with the HTML5 Canvas element much easier.
http://createjs.com/
MIT License
8.11k stars 1.97k forks source link

added mediump precission fallback in shaders #1053

Closed Nestorferrando closed 3 years ago

Nestorferrando commented 3 years ago

Hello, this is a small fix that implemented for the stageGL shaders. It allows to run the webGL render system in low-end mobile GPUs like the ARM mali-400 (https://developer.arm.com/ip-products/graphics-and-multimedia/mali-gpus/mali-400-gpu)

danzen commented 3 years ago

Hi @Nestorferrando - thanks for this. Looking into it on our side. On your side, have you tested this a lot? Somewhat? A little? It looks like a straight forward update but I am not an expert in this area - just starting to dig into it and looking for some confirmation from the folks here. Cheers.

Nestorferrando commented 3 years ago

Hi! this fix (among others that I will PR later) have been in production in a couple of products for about one year with no known complaints (https://play.google.com/store/apps/details?id=com.playjoy.app&hl=en_US, https://www.3cherry.com/). Also, before releasing it, we tested it in a wide range of android and a couple of iphone models. Of course, if you can get a second opinion it will be great :-D