search

CreateJS / EaselJS

The Easel Javascript library provides a full, hierarchical display list, a core interaction model, and helper classes to make working with the HTML5 Canvas element much easier.
http://createjs.com/
MIT License
8.11k stars 1.97k forks source link

Different Luminence values for Saturation vs Hue #1074

Closed leonwind closed 1 year ago

leonwind commented 1 year ago

Hi,

I was just wondering if there is a specific reason why you are using different luminence values for Saturation and for Hue.

As far as I know the values for Hue should be correct if you use sRGB which uses the BT.709 standard underneath. The relative luminence values for it are described here and match with your Hue adjustment but not with the Saturation one.

Thanks a lot! Leon

gskinner commented 1 year ago

it's been a long time, but iirc it is a direct copy of how the Flash (now Animate) authoring environment applies color effects.

leonwind commented 1 year ago

The only source I could find for this is this old documentation from 1993. He quoted that these values are better for the linear RGB space but I think the current best practise has changed in the last 30 years, time flies :D, and I think your Hue values are actually providing better results.

But no need to change, I was just curious about it!

EDIT: Also wondering: How did you find the information about Flash / Animate using these values? Did they document this somewhere? I mean it is closed source by Adobe, right?

danzen commented 1 year ago

I think Grant has a little "in" at Adobe on occasion! I am closing this, but anyone is welcome to continue the conversation!