search

CreateJS / PreloadJS

PreloadJS makes preloading assets & getting aggregate progress events easier in JavaScript. It uses XHR2 when available, and falls back to tag-based loading when not.
http://createjs.com/
MIT License
2.88k stars 761 forks source link

FileLoad events are lost when the queue is paused due to an error on any file #231

Open chepemago opened 7 years ago

chepemago commented 7 years ago

When there is an error and stopOnError is set to true, the queue is stopped but if some files are loaded at the same time, the event fileLoad is not dispatched. If then, the queue is resumed, the files which were loaded but not "reported" are missed. This issue can be reproduced when trottling the network (using low bandwidth)

lannymcnie commented 7 years ago

What is the expectation here? If a file completes in a stopped queue, we currently ignore events. Maybe we should queue them up, and dispatch them ALL once the queue is restarted?

chepemago commented 7 years ago

Yes that can be one valid approach. The idea is that the user needs to control which files have succeeded and which not.

El 23 oct. 2017 11:39 a. m., "Lanny McNie" notifications@github.com escribió:

What is the expectation here? If a file completes in a stopped queue, we currently ignore events. Maybe we should queue them up, and dispatch them ALL once the queue is restarted?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CreateJS/PreloadJS/issues/231#issuecomment-338738669, or mute the thread https://github.com/notifications/unsubscribe-auth/AbIsl24r8TsOQNG5EetyvyX9KKWlLCNSks5svM9JgaJpZM4NSPCS .