preferXHR of FontLoader should be removed

CreateJS / PreloadJS

PreloadJS makes preloading assets & getting aggregate progress events easier in JavaScript. It uses XHR2 when available, and falls back to tag-based loading when not.

http://createjs.com/

MIT License

2.88k stars 761 forks source link

preferXHR of FontLoader should be removed #237

Open FumioNonaka opened 7 years ago

FumioNonaka commented 7 years ago

https://github.com/CreateJS/PreloadJS/blob/7a3a39cbc6981241d867ad64935189fac9b3f08a/src/preloadjs/loaders/FontLoader.js#L40 The second argument of FontLoader, preferXHR , is not documented. And FontLoader does not support tag-based loading. Therefore, it should be removed and pass true to the constructor of the superclass.

function FontLoader(loadItem) {
    this.AbstractLoader_constructor(loadItem, true, loadItem.type);