RequestUtils.getTypeByExtension() and WebM format

CreateJS / PreloadJS

PreloadJS makes preloading assets & getting aggregate progress events easier in JavaScript. It uses XHR2 when available, and falls back to tag-based loading when not.

http://createjs.com/

MIT License

2.88k stars 764 forks source link

RequestUtils.getTypeByExtension() and WebM format #263

Open djipco opened 5 years ago

djipco commented 5 years ago

In the RequestUtils.getTypeByExtension() method, the "webm" extension is there twice (line 110 and line 114). Is this intended?

I don't see how it could be detected as anything but createjs.Types.SOUND and I'm not sure this is necessarily the best default value for the WebM format.

I understand that we should specify the type explicitely but I stumbled upon that, while debugging a related issue, and figured I should report it.

lannymcnie commented 5 years ago

It is probably just a mistake. If memory serves, there was a specific edge-case that that type handled. I am not sure it's still required.

Cheers,

djipco commented 5 years ago

I submitted PR #264 to fix this little mistake.