[WIP] - Refactor SoundJS lib with good practices

CreateJS / SoundJS

A Javascript library for working with Audio. It provides a consistent API for loading and playing audio on different browsers and devices. Currently supports WebAudio, HTML5 Audio, Cordova / PhoneGap, and a Flash fallback.

http://createjs.com/

MIT License

4.42k stars 838 forks source link

[WIP] - Refactor SoundJS lib with good practices #303

Open calebesantos opened 6 years ago

calebesantos commented 6 years ago

Hello, I have a college evaluation to help with good coding practices a repository. I hope my changes helps xD

Best practices or guidelines related to:

Functions
Variables, objects or data structures
Defensive programming or error handling
Classes

gSkinner-Blair commented 6 years ago

Hey there! Thanks for the contribution! We'll review this when we get a chance to see if there's good value in these changes. Unfortunately, we might not get to it right away - vetting these changes might be a fairly large task given the amount of them, and things like needing to make sure this works with our autodocs etc. Right now our priority on the CreateJS libraries is working on the 2.0 versions, which in the case of SoundJS 2.0, is a complete rewrite.

calebesantos commented 5 years ago

Thanks for review! Your feedback was very important!

mymomscrazy commented 5 years ago

Genius reply. Thank you so much