CreateJS / SoundJS

A Javascript library for working with Audio. It provides a consistent API for loading and playing audio on different browsers and devices. Currently supports WebAudio, HTML5 Audio, Cordova / PhoneGap, and a Flash fallback.
http://createjs.com/
MIT License
4.44k stars 835 forks source link

SoundJS 2.0 uses `loops` instead of `loop` #319

Open probityrules opened 5 years ago

probityrules commented 5 years ago

For backwards compatibility, I might recommend making this options.loop instead of options.loops. Unless maybe it's going to behave functionally different from the original 1.0 loop property?

https://github.com/CreateJS/SoundJS/blob/03191e64b01b349ff301bf487beaf2f5a9f5e315/src/Playback.js#L72

(It took me some time to figure out that the spec for this changed, so I wanted to note it here.)