Creatide / AnimateMate

Create your animations directly in Sketch using AnimateMate.
http://AnimateMate.com
MIT License
1.33k stars 78 forks source link

Sketch 42 and 44, Crash on Export, recreating files as they are removed #28

Closed Lucas-gronlund closed 7 years ago

Lucas-gronlund commented 7 years ago

As the title suggest, AnimateMate is doing some really weird stuff right now. As you export, Sketch crashes but creates the animation. Sometimes they don't work either. After that, you cannot delete the gif, it recreates itself every minute taking up loads of space on my drive. Until i restart my Mac.

Also thanks for creating AnimateMate, it's the only plugin I use for Sketch, it's so amazing!

Lucas-gronlund commented 7 years ago

After further testing, the freeze goes away after some seconds as long as I don't add a mask to the artboard

niittymaa commented 7 years ago

If you do not wait until process is complete it will create file again ang again. All that happens inside SIP command in terminal. It uses gifsicle library for gif converting process. So that explains why it creates again if you delete file before complete. So with big image size or animation size, exporting gif is not recommended. It could take too much time.

But that sounds very wierd if it doesn't stop until the restart! Never happened for me yet. I have just tested out plugin with Sketch 44.1 and Sierra OS, but everything seems to work fine for me while exporting. If you share some example file I could also test if that makes same for me...

nakele commented 7 years ago

@Lucas-gronlund I have 44.1 on El Capitan, creating a GIF will take some time but for me if I let it be eventually it works fine.

Perhaps you could send a Sketch sample file to export to gif so that I can try on my machine

Lucas-gronlund commented 7 years ago

BrokenAnimation.zip

Here is an example, note that the text jumped down to bottom right corner after the crash as well

nakele commented 7 years ago

Hi @Lucas-gronlund, I've reanimated the text, I'm assuming that the text should just pan from left to right. This is the result after a whole minute waiting and do wait, just don't do anythingelse after you export and just wait to be done: apple tv_0-50

The poor colour gradation is a GIF limitation, nothing to do with this plugin, no way to solve it, it's just a limitation of how GIF works.

In regards to the text end up in the wrong position after export it's an issue I notice as well when you animate something in a group, have a look at this thread: https://github.com/Creatide/AnimateMate/issues/27

In any case I believe it's solved, if you re-download the plugin now it should be fixed. Make sure U use Sketch version >= 44.1

Lucas-gronlund commented 7 years ago

Thanks @nakele I actually got it to work now, the infinite crash still persists but now the result is as expected 👍 Really appreciate the help, thank you!

niittymaa commented 7 years ago

@Lucas-gronlund you can avoid that stupid jumping problem with just adding "empty" artboard sized rectangle, so now it thought that group is starting from top left corner.

image copied on 2017-05-25 at 19 13 pm

Here is example.

apple tv_0-50 BrokenAnimation.sketch.zip