soc-pe-bot
commented
1 year ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Inconsistent error message regarding invalid index for remark command
Similar to the issue of index error message for edit command, provided a positive exceeded index is met with the correct error message, but an index of smaller or equal to 0 has a different error message simply stating wrong format of command, when in reality the command format is legitimate.
[original: nus-cs2103-AY2223S2/pe-interim#2297] [original labels: severity.Low type.FunctionalityBug]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
It is stated that the INDEX should be a positive integer. Therefore, the error message for index '0' and index '-999' should be the same as both integers are not positive. (Positive integers are integers that are more than or equal to 1). It is indeed an invalid command format error and our error messages are the expected behaviour of the given input. Hence, it is not a bug since the command formats are not legitimate.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** Yes, index is a positive integer, but the behaviour for an out of bounds index should be consistent for both exceeded and too small index.
If an index longer than the list is provided for, e.g., 9999 when the list length is 12, the error message provided correctly shows the index being invalid is provided.
However, if we attempt index 0 or a negative index, it simply says wrong command format, when in reality I believe the intended behaviour should be in tandem with the prior error.