search

CreativeIT / getmdl-select

Select for material-design-lite
http://creativeit.github.io/getmdl-select/
MIT License
301 stars 87 forks source link

Label stays when selecting a value, if the input starts with no value #15

Closed fmaylinch closed 8 years ago

fmaylinch commented 8 years ago

It's related to this issue.

randrianov commented 8 years ago

thanks @fmaylinch will have a look

fmaylinch commented 8 years ago

I think you just need to add

dropdown.classList.add("is-dirty");

on line 17

fmaylinch commented 8 years ago

Thank you for the component @randrianov

fmaylinch commented 8 years ago

I used classList but I guess it's better to use className.

http://stackoverflow.com/questions/507138/how-do-i-add-a-class-to-a-given-element

randrianov commented 8 years ago

@fmaylinch maybe do you want to make a pull-request, ha?

fmaylinch commented 8 years ago

Ok, I'll try :)

On Mon, Apr 4, 2016 at 2:57 PM, raman notifications@github.com wrote:

@fmaylinch https://github.com/fmaylinch maybe do you want to make a pull-request, ha?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/CreativeIT/getmdl-select/issues/15#issuecomment-205285682

franckevva commented 8 years ago

@fmaylinch Thanks for your work!