CreativeInquiry / PEmbroider

Embroidery Library for Processing
Other
442 stars 28 forks source link

Single line Embroidery #28

Closed tatyanade closed 4 years ago

tatyanade commented 4 years ago

I think it would be beneficial to implement a small repeat stitch at the beginning and end of each line

When using a sewing machine for sewing, when you reach the end of a stitch, you go over the same spot a few times (reverse then go forward again) so that the thread is effectively tied and it does not unravel when you snip the extra thread. you can see this in a few spots on the ruler in #17 and the image below where I did a test on some lines - even just going over the last stitch one time helped a lot, image You can see the bottom version has unraveled in a few places but the top hasn't - I manually went over the last stitch one time, but it should work and look something like this (but with all the stitches having the same Y values) - I'll manually test this out image

another issue is that lines intersecting at one point don't appear to intersect unless both lines stop at the intersection:

image

you can see the top vertical line seems to be floating about the horizontal line, but if the horizontal line had a stitch start and stop at the intersection there would be no way for it to move out of the way.

LingDong- commented 4 years ago

added in 4b835ab6c6d35b3bd9b1ef13b439ec8b1ad70594

E.repeatEnd(x); // x is the length of the red and blue thing in the drawing

to add this effect to all end stitches currently in the design

golanlevin commented 4 years ago

Excellent! @tatyanade, please test :)

tatyanade commented 4 years ago

image image

Looks great!