search

CreativeInquiry / PEmbroider

Embroidery Library for Processing
Other
442 stars 28 forks source link

E.repeatEnd(); not working #57

Closed tatyanade closed 4 years ago

tatyanade commented 4 years ago

E.repeatEnd(); seems like it is not working anymore and does nothing

LingDong- commented 4 years ago

I haven't changed repeatEnd. And I just tested, it is working correctly for me. Did you pass in the correct parameter for the length of the repeat? Could you see it in E.visualize()? What shape were you trying to run it on?

LingDong- commented 4 years ago

btw, see https://github.com/CreativeInquiry/PEmbroider/issues/52 for new API

tatyanade commented 4 years ago

Had been trying with a single line and i wasnt showing up regardless of value; Added two more lines with different values and it shows up for all but the last line

1 line has no repeat 2020-06-25_02h11_39

three lines has repeats on the first two called lines 2020-06-25_02h10_32

two lines only does repeats on one line 2020-06-25_02h12_30 2020-06-25_02h12_48 2020-06-25_02h14_45

Will update my PEmbroider lib to test the new API

tatyanade commented 4 years ago

I think its skipping one? so if i do line; repeatEnd(12); line; repeatEnd(3); the first line repeats but with len 3 not 12 and the 2nd doesnt repeat

tatyanade commented 4 years ago

Actually I think maybe the whole issue here is I thought it was a function you call in the beginning but you call it at the end

LingDong- commented 4 years ago

Yes it should be called at the end.

But nevermind because I just added a new API beginRepeatEnd(x) and endRepeatEnd. see #52