Angled Stroke Demo

[golanlevin]

Hi @tatyanade , @LingDong- , I've made an angled stroke demo: PEmbroider_stroke_outlines_3 It should look like this:

Taytana could you please render this with a dense shiny thread?

@LingDong- , Wwhen strokeMode is set to PERPENDICULAR there is a new error, an extra line:

Thanks much, Golan

[tatyanade]

Ooo Yes I will render right now

[tatyanade]

Here's that with a spacing of three; ill try it with a larger stitchlength (theres the ridge down the middle) Also doing more prints rn so I will clean extra threads and scan in when i've filled the hoop

[LingDong-]

@golanlevin @tatyanade

• Fixed extra line for PERPENDICULAR fa90ce12fe51d0a7bb88c4f1809bd95a94a4edf6

• ANGLED did not have the improvement I made last night, so it probably still had two passes and the sorting is not optimal in the photo. This is now fixed: fa90ce12fe51d0a7bb88c4f1809bd95a94a4edf6. Please pull thanks!

[golanlevin]

Hi @tatyanade please pull Lingdong's latest changes (it should get rid of the line down the middle). I have also re-designed this example slightly, please use the latest version, I made it larger and nicer.

[tatyanade]

The round stroke caps are too dense and cause the thread to break - tried strokeCap(SQUARE) which didnt change anything but will fiddle around and try on a diff shape

[LingDong-]

Added E.PERPENDICULAR_STROKE_CAP_DENSITY_MULTIPLIER = 0.5

[tatyanade]

Will send pics when its finished but it is looking great and the multiplier did the trick!

[tatyanade]

It worked with no technical issues, however visually the change in line for the circles could look nicer; I think if the half-circle edge followed the last tangent line's angle (something like this) it would look better

[LingDong-]

The line caps and joins are generated with a unified algorithm that handles all cases (line ends, corners, curves etc)

To have the other look we will need to make a special case for line ends of unclosed polylines.

[tatyanade]

I think a special case for unclosed lines makes sense

[LingDong-]

Added special case: a003bc3625a8a81da136a27c02d76dd34199e509

[tatyanade]

Awesome; looks great! - will scan after clean up and add to the repo