search

CreativeMD / CMDCam

GNU Lesser General Public License v3.0
37 stars 21 forks source link

Fixed a crash when CreativeCore is not installed #38

Closed whitebear60 closed 4 years ago

whitebear60 commented 4 years ago

Now Forge will tell the user to install CreativeCore (instead of crashing Minecraft)

CreativeMD commented 4 years ago

Unfortunately this won't fix the issue. It will still crash.

whitebear60 commented 4 years ago

My changes tells Forge that CMDCam depends on CreativeCore. When CreativeCore is absent, now Forge should show this window instead of simple crashing Minecraft without any messages: Absent core mod

whitebear60 commented 4 years ago

I haven't made CMDCam independent of CreativeCore, no.

CreativeMD commented 4 years ago

For real? Oh damn, guess I will change it for all my mods then.

whitebear60 commented 4 years ago

I have learned about this just recently, and, you can see examples of using multiple dependencies in Astral Sorcery repository, for example. If you need this.

CreativeMD commented 4 years ago

I knew about the dependency thingy, but it never prevented the crash before CMDCam crashed before the screen appeared (because it has a core mod which requires CreativeCore).

whitebear60 commented 4 years ago

Check the mod start without dependencies before publishing mods in the future))

whitebear60 commented 4 years ago

This bugfix should be released on Curseforge as quick as possible))

CreativeMD commented 4 years ago

I'm sorry, but I can't at the moment. I will release a wave of fixes and ports once I have done my exams. So at around the beginning of august.