search

CreativeMD / CMDCam

GNU Lesser General Public License v3.0
37 stars 21 forks source link

Command Argument Registry #66

Closed CyanideX closed 2 years ago

CyanideX commented 2 years ago

Need to add command arguments to the COMMAND_ARGUMENT_TYPE_REGISTRY.

https://github.com/CreativeMD/CMDCam/blob/1.19/src/main/java/team/creative/cmdcam/CMDCam.java#L83-L87

Log: https://paste.ee/p/0tT5q

CreativeMD commented 2 years ago

Fixed in the newest version. Thanks for reporting this issue.

CyanideX commented 2 years ago

It seems you missed one argument:

https://github.com/CreativeMD/CMDCam/blob/1.19/src/main/java/team/creative/cmdcam/common/command/argument/CamPitchModeArgument.java

CreativeMD commented 2 years ago

Fixed! Thanks for reminding me.

CyanideX commented 2 years ago

Great! Will you be releasing the updated lib too? I'm currently having issues with it trying to find a method from CreativeCore.

CreativeMD commented 2 years ago

Answered you on discord. New CreativeCore version is out and the fov issue will be fixed soon.