search

CreativeMD / CraftingManager

GNU General Public License v3.0
1 stars 1 forks source link

CraftingManager memory leak? #32

Closed LuxusDarkangel closed 9 years ago

LuxusDarkangel commented 9 years ago

Since i'm using CM TPS from my server are going down. It sometimes send me this message:

[03:01:15 ERROR]: Detected ongoing potential memory leak. 500 packets have leaked. Top offenders [03:01:15 ERROR]: CMPacket : 497 [03:01:15 ERROR]: FML : 3

CreativeMD commented 9 years ago

That is not a memory leak, but it shows how many packets are send. Not an issue.

LuxusDarkangel commented 9 years ago

It's not showing how many packets are sended, it's showing how many packets (from all) are leaked (violations), i think that's a big issue. So if you want to take a look at it, i can provide you timings, opis info, another mods in the environment or whatever you want, just ask for it.

CreativeMD commented 9 years ago

No, that is not an issue ... Sorry i write that this would be a memory leak :D , but i wanted to say that this is no memory leak. This message comes up if your server has problems to handle all the packets, it shows how many packets were send from which mod, not a problem of my mod, but your server is not fast enough to handle the situation properly.

LuxusDarkangel commented 9 years ago

Sorry, but this is a problem of your mod xD. I've been using JD to take a look to your network code, and it's outdated, that's why its causing memory leaks, here you can see that's true (this is the code you're using): http://www.minecraftforge.net/wiki/Tutorials/Packet_Handling You need to update it (here you have a very nice tutorial to do this: http://www.minecraftforum.net/forums/mapping-and-modding/mapping-and-modding-tutorials/2137055-1-7-x-1-8-customizing-packet-handling-with)

CreativeMD commented 9 years ago

Never heard about that, but my system works for now (tested it very often), YES if this cause memory leaks i will change my system of course. Will add this to my ToDo List.

LuxusDarkangel commented 9 years ago

Thanks :). Sorry for bug you so much, but this causes server TPS to drop A LOT, so i think that's good for you to fix it, so more people can use your mod n.n

LuxusDarkangel commented 9 years ago

Can i ask for a ETA?

CreativeMD commented 9 years ago

ETA? but anyway i will release a fix of this today, hopefully it works out :D

LuxusDarkangel commented 9 years ago

ETA = a date for the release, but you already said it.

CreativeMD commented 9 years ago

It's already out :D