CreativeMD / ItemPhysic

GNU Lesser General Public License v3.0
33 stars 20 forks source link

When charging up to throw, the drop animation plays multiple times #127

Closed BugmanBugman closed 3 years ago

BugmanBugman commented 3 years ago

https://streamable.com/ygunyo

BugmanBugman commented 3 years ago

This wouldn't happen in 1.12 versions, where the drop animation would only play when you threw it.

CreativeMD commented 3 years ago

Actually this is a feature. I wanted to add this animation to make the player realize that a throw is charging up. It's also not a drop animation, but the "general interaction" one (same as placing a block for example). Should I really remove it (because i actually think it's better)?

BugmanBugman commented 3 years ago

Ahh ok, just wanted to make sure

On Oct 12, 2020, at 12:05 PM, CreativeMD notifications@github.com wrote:



Actually this is a feature. I wanted to add this animation to make the player realize that a throw is charging up.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/CreativeMD/ItemPhysic/issues/127#issuecomment-707239578, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJWX3OS6D45G2L3HLJGADC3SKMZMXANCNFSM4SKFQBUQ.

zDragoNzz commented 3 years ago

I think you should add an option to enable or disable it, i don't think that animation looks right for it, maybe the bow animation would fit it better

CreativeMD commented 3 years ago

It's not that easy to disable it.

zDragoNzz commented 3 years ago

It's not that easy to disable it.

that's unfortunate, maybe using that bow charging animation if possible would look a lot better

CreativeMD commented 3 years ago

That's not how it works unfortunately.