search

CreativeMD / ItemPhysic

GNU Lesser General Public License v3.0
32 stars 17 forks source link

Incompatible with Arclight #141

Closed ZekerZhayard closed 3 years ago

ZekerZhayard commented 3 years ago

Related to https://github.com/IzzelAliz/Arclight/issues/50

Arclight is a Bukkit server implementation on Forge using Mixin. It will crash if ItemPhysic installed with it.

debug.log: https://paste.ubuntu.com/p/75hdRWS75p/

Arclight Version: 1.16.5-1.0.12-SNAPSHOT-bcf3f33 ItemPhysic Version: v1.4.15_mc1.16.5

I noticed that both Arclight and ItemPhysic modify the method net.minecraft.entity.item.ItemEntity:func_70097_a, so it caused a crash.

I think ItemPhysic's modification is too radical, which may cause it to potentially conflict with other mods. Since a large number of Core Mods have changed from using ASM to using Mixin, I suggest ItemPhysic to make corresponding changes (Use partial modifications instead of replacing the entire method). Thanks!

CreativeMD commented 3 years ago

Should be fixed in the newest version! Sorry that it took me so long, I had to do some other things first.