search

CreativeMD / LittleFrames

GNU Lesser General Public License v3.0
13 stars 7 forks source link

Implemented WATERMeDIA #57

Closed SrRapero720 closed 1 year ago

SrRapero720 commented 1 year ago

Changes

Information

VideoDisplay doesn't works with streams, playback is stepped, thats because this code cant detect some .m3u8 streams... specially twitch or kick.com streams

this bug is present on old versions... (extracting stream links manually) https://github.com/CreativeMD/LittleFrames/blob/d4de643b6313effa0e919bc58fa25dd5f1875764/src/main/java/team/creative/littleframes/client/display/FrameVideoDisplay.java#L171

SrRapero720 commented 1 year ago

TESTING WITH YOUTUBE VIDEOS

2023-07-07_16h41_48 2023-07-07_16h41_43

FORCED DISABLE VLC (how error picture looks)

2023-07-07_16h37_46

SrRapero720 commented 1 year ago

Fixes #52 and #53

CreativeMD commented 1 year ago

Yeah, it is tricky to make it work with streaming, because they work in weird ways. This line: https://github.com/CreativeMD/LittleFrames/blob/d4de643b6313effa0e919bc58fa25dd5f1875764/src/main/java/team/creative/littleframes/client/display/FrameVideoDisplay.java#L171 worked in the past. This should be no difference when using watermedia, right? I'm a bit confused about this part.

SrRapero720 commented 1 year ago

I Made few test but isn't working anymore. Is not caused by watermedia, probably Is how kick.com or twitch.com streams works

All streams plays with "lag" (got stunned trying to sync position) I add the comment in any case someone report that bug

SrRapero720 commented 1 year ago

I use VideoLANPlayer#isStream to avoid that. but is a unsafe method (WMedia 1.3.3). because every m3u8 stream is detected as stream, but for example twitch VODs aren't streams and uses m3u8.

im gonna fix that watermedia method (in 1.3.6).

CreativeMD commented 1 year ago

Hey, thanks a lot for all your work. I wanted to merge it on Monday, but I had other things to do. Same yesterday and today. I'm sorry but I need some time to do the transition properly. That's why I will merge this next week.

SrRapero720 commented 1 year ago

Ok, dont worry. I am doing some stuff un watermedia to enhance API and loading performance. So before end this week i'll make extra commits to use /support latest watermedia versión.

SrRapero720 commented 1 year ago

i just change watermedia version (gradle) and use a better way to identify if watermedia have binaries of current OS (in case watermedia have VLC binaries for macos or linux

CreativeMD commented 1 year ago

Released it for 1.19.2, 1.19.4 and 1.20.