search

CreativeMD / LittleTiles

GNU Lesser General Public License v3.0
166 stars 53 forks source link

Pretty substantial duplication bug, can I report this to someone privately? #272

Closed OmaiGrundles closed 4 years ago

OmaiGrundles commented 4 years ago

This is for version 1.5.0-pre167, used in a modpack I have been playing.

I don't want this awesome mod(seriously this mod is amazing) to be removed from any modpacks due to this bug so I would like to report it privately somehow. Is there a way for me to do so? I am not well-versed in using GitHub.

Edit: Though to be fair it isn't quite as bad as another dupe bug mentioned here, its also easier to do as the other dupe bug needs 2+ people.

kirokadura commented 4 years ago

You can DM me about it on our Discord. I'll relay it to CreativeMD.

kirokadura commented 4 years ago

Also, it'd be very helpful if you could test it on pre168 as well, since it's the latest one.

OmaiGrundles commented 4 years ago

Discord link?

kirokadura commented 4 years ago

https://discord.gg/UyAShS

CreativeMD commented 4 years ago

This bug should be fixed in the newest pre-release. Can you confirm it?

OmaiGrundles commented 4 years ago

Sorry for the late reply. Ive updated to the latest and its now partially fixed.

The blocks that would cause crashes when trying to interact after placing segments with LittleTiles no longer seems to crash.

But the small selection of blocks that duplicate still duplicate. I also found a few more blocks that have this issue. Ill give kiro a list of affected blocks ive found

CreativeMD commented 4 years ago

You can also report them here for more clarity. I don't think anyone will exploit it that fast.

OmaiGrundles commented 4 years ago

ok well some solid vanilla blocks (furnace and dropper for example) can be duplicated this way, the Automated Precision Dropper from AA, and the Inferium/etc furnaces from Mystical Agriculture also can be duplicated this way

Edit: Its almost as if any block that has 'dispenser' 'dropper' or 'furnace' in its name can be duplicated.... The powered furnace(AA), Nuclear Furnace(Nuclearcraft), Alloy furnace(Nuclearcraft), and red stringed dispenser(botania) also are dupeable

Edit2: Ok that doesnt apply to everything, Redstone Furnace(thermal) isnt dupable

Edit3: Finally found one thing that doesnt fit the previous categories that is dupeable, the Advanced Oxygen Compressor from Extra Planets, and the Methane Syntysizer from Galacticraft Planets

CreativeMD commented 4 years ago

The issue is fixed in the newest update. I will release it soon. Thanks for reporting this serious issue!

OmaiGrundles commented 4 years ago

No problem! Out of curiosity, what exactly links all of those blocks i mentioned?

CreativeMD commented 4 years ago

As I started with LT I tried to implement as many methods of the block as possible. So once a tile is placed it will forward two methods to the block class. Most directional blocks use these methods to set the direction. So if you place a furnace it will change it's face direction depending on the player. This means as soon as a furnace tile is placed, a furnace block will be placed instead. Many other blocks do it like that as well. It's quite shocking that this issue has never been reported before.

OmaiGrundles commented 4 years ago

maybe im just the only one crazy enough to want a furnace as a decoration XD

CreativeMD commented 4 years ago

Yeah, but there are always some issues with those kind of blocks. The will be forbidden in the next release (they should be forbidden already, but I messed that one up. You can use it with the chisel, but you can't hammer it for example).

CreativeMD commented 4 years ago

New pre-release is out. Thanks for reporting this issue!

Lgmrszd commented 4 years ago

Just found another duplication bug, and the discord link is outdated. Where can I report it?