search

CreativeMD / OnlinePictureFrame

GNU Lesser General Public License v2.1
22 stars 9 forks source link

[BUG] Optifine Connected Textures causes crash #26

Closed xunto closed 5 years ago

xunto commented 5 years ago

Hi! Great mod! I think I found some problem with it though.

If you place two picture frames near while having resourcepack and with connected textures (optifine) enabled, it hangs the client (very badly).

You should place them like this for this bug to appear (disabled connected textures to show). 2019-02-09_10 07 43

Errors in console (they appear as in infinite loop):

[09:49:43] [main/INFO] [STDERR]: [java.lang.Throwable:printEnclosedStackTrace:709]:   at net.optifine.ConnectedTextures.getNeighbourIcon(ConnectedTextures.java:1581)
[09:49:43] [main/INFO] [STDERR]: [java.lang.Throwable:printEnclosedStackTrace:709]:   at net.optifine.ConnectedTextures.isNeighbour(ConnectedTextures.java:1537)
[09:49:43] [main/INFO] [STDERR]: [java.lang.Throwable:printEnclosedStackTrace:709]:   at net.optifine.ConnectedTextures.isNeighbour(ConnectedTextures.java:1517)
[09:49:43] [main/INFO] [STDERR]: [java.lang.Throwable:printEnclosedStackTrace:709]:   at net.optifine.ConnectedTextures.getConnectedTextureHorizontal(ConnectedTextures.java:1641)
[09:49:43] [main/INFO] [STDERR]: [java.lang.Throwable:printEnclosedStackTrace:709]:   at net.optifine.ConnectedTextures.getConnectedTexture(ConnectedTextures.java:562)
[09:49:43] [main/INFO] [STDERR]: [java.lang.Throwable:printEnclosedStackTrace:709]:   at net.optifine.ConnectedTextures.getConnectedTextureSingle(ConnectedTextures.java:382)
[09:49:43] [main/INFO] [STDERR]: [java.lang.Throwable:printEnclosedStackTrace:709]:   at net.optifine.ConnectedTextures.getConnectedTextureMultiPass(ConnectedTextures.java:311)
[09:49:43] [main/INFO] [STDERR]: [java.lang.Throwable:printEnclosedStackTrace:709]:   at net.optifine.ConnectedTextures.getConnectedTexture(ConnectedTextures.java:122)
[09:49:43] [main/INFO] [STDERR]: [java.lang.Throwable:printEnclosedStackTrace:709]:   at net.optifine.model.BlockModelCustomizer.getRenderQuads(BlockModelCustomizer.java:113)
[09:49:43] [main/INFO] [STDERR]: [java.lang.Throwable:printEnclosedStackTrace:709]:   at net.optifine.model.BlockModelCustomizer.getRenderQuads(BlockModelCustomizer.java:67)
[09:49:43] [main/INFO] [STDERR]: [java.lang.Throwable:printEnclosedStackTrace:709]:   at sun.reflect.GeneratedMethodAccessor82.invoke(Unknown Source)
[09:49:43] [main/INFO] [STDERR]: [java.lang.Throwable:printEnclosedStackTrace:709]:   at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[09:49:43] [main/INFO] [STDERR]: [java.lang.Throwable:printEnclosedStackTrace:709]:   at java.lang.reflect.Method.invoke(Method.java:498)
[09:49:43] [main/INFO] [STDERR]: [java.lang.Throwable:printEnclosedStackTrace:709]:   at com.creativemd.creativecore.client.mods.optifine.OptifineHelper.getRenderQuads(OptifineHelper.java:108)
[09:49:43] [main/INFO] [STDERR]: [java.lang.Throwable:printEnclosedStackTrace:709]:   at com.creativemd.creativecore.client.rendering.RenderCubeObject.getBakedQuad(RenderCubeObject.java:271)
[09:49:43] [main/INFO] [STDERR]: [java.lang.Throwable:printEnclosedStackTrace:709]:   at com.creativemd.creativecore.client.rendering.RenderCubeObject.getBakedQuad(RenderCubeObject.java:275)
[09:49:43] [main/INFO] [STDERR]: [java.lang.Throwable:printEnclosedStackTrace:709]:   at com.creativemd.creativecore.client.rendering.model.CreativeBakedModel.getBlockQuads(CreativeBakedModel.java:118)
[09:49:43] [main/INFO] [STDERR]: [java.lang.Throwable:printEnclosedStackTrace:709]:   at com.creativemd.creativecore.client.rendering.model.CreativeBakedModel.getBlockQuads(CreativeBakedModel.java:219)
[09:49:43] [main/INFO] [STDERR]: [java.lang.Throwable:printEnclosedStackTrace:709]:   at com.creativemd.creativecore.client.rendering.model.CreativeBakedModel.func_188616_a(CreativeBakedModel.java:75)
CreativeMD commented 5 years ago

Can you send me the entire crash-report?

xunto commented 5 years ago

@CreativeMD latest.log

xunto commented 5 years ago

Any luck?

CreativeMD commented 5 years ago

I don't have any time at the moment, sorry :( I have to learn for exams, I will have plenty of time next week.

xunto commented 5 years ago

Ah, I understand. Had 2 sleepless nights that weekend. So no problem, thanks. I'll wait.

CreativeMD commented 5 years ago

Does this crash still happen if LittleTiles is installed?

xunto commented 5 years ago

I'll check.

CreativeMD commented 5 years ago

Update CreativeCore to v1.9.41 and it should work.

xunto commented 5 years ago

@CreativeMD Sorry, had some exams too. :D

I updated CreativeCore and installed LittleTiles but crash still happens.

xunto commented 5 years ago

Have you tried to install mod I have? And crash doesn't happen to you? Just want to make sure.

CreativeMD commented 5 years ago

Works just fine, using: ConquestReforged-3.0.2-mc1.12.2.jar CreativeCore_v1.9.41_mc1.12.2.jar OptiFine_1.12.2_HD_U_E3.jar OnlinePicFrame_v1.4.23_mc1.12.2.jar

xunto commented 5 years ago

Wait, yes it does work! But only after I deleted little tiles. :D

CreativeMD commented 5 years ago

Test it with LittleTiles and it still works just fine.