search

CreativeMD / PlayerRevive

GNU Lesser General Public License v3.0
11 stars 22 forks source link

[Forge] [1.20.1] The Aether mod grants players to bypass bleed out. #142

Closed KateReller closed 4 months ago

KateReller commented 6 months ago

After going through all of my mods, it turns out that The Aether mod lets players bypass bleed out by disconnecting when they are in the bleed out state.

CreativeMD commented 6 months ago

Is is a known issue with FirstAid and Spice Of Life (all versions except Onion). Can you send me your mod list?

KateReller commented 6 months ago

My (and my server's) modpack has been updated and has new mods. But my logs from my comment from a previous issue still shows the mods I had installed at the time this issue was created.

CreativeMD commented 5 months ago

I have reported the issue to the aether team. I tested it myself with just PlayerRevive and The Aether installed and the issue is still there. Let's hope the issue can be fixed.

bconlon1 commented 4 months ago

You could likely solve this by setting the SubscribeEvent to a higher priority, if you want the kill behavior to be guaranteed. Let me know if that works. https://github.com/CreativeMD/PlayerRevive/blob/bec1bdf38aaf212908767a25d3822c7897290879/src/main/java/team/creative/playerrevive/server/ReviveEventServer.java#L71

CreativeMD commented 4 months ago

Actually that works! Thanks @bconlon1 for suggesting this solution (probably by far the easiest). New version with this fix is out.