search

CreativeSDK / phonegap-plugin-csdk-image-editor

A PhoneGap plugin for the Creative SDK Image Editor.
Apache License 2.0
35 stars 15 forks source link

IOS: Missing resource files #1

Closed SanHoser closed 8 years ago

SanHoser commented 8 years ago

In the plugin.xml two resource files are defined, but are missing from the git repo.

    <resource-file src="src/ios/AdobeCreativeSDKFrameworks/AdobeCreativeSDKImage.framework/Versions/A/Resources/AdobeCreativeSDKImageResources.bundle" />
    <framework src="src/ios/AdobeCreativeSDKFrameworks/AdobeCreativeSDKImage.framework" custom="true" />

This will cause cordova platform add ios to fail after the plugin has been installed.

macdonst commented 8 years ago

@SanHoser yeah, I mention that you need to get the iOS SDK and extract it to the src/ios directory in the README. Once cordova-ios supports cocoapods the plan is to include the SDK as a cocoapod so you can skip this step.

Make sense?

vernondegoede commented 8 years ago

Should the src/ios folder be in the root of the Cordova project?

macdonst commented 8 years ago

@vernondegoede nope, it is fine where it is. What matters is that the path in plugin.xml is correct.

vernondegoede commented 8 years ago

@macdonst Wow, you're fast. I'll try this now :)

macdonst commented 8 years ago

@vernondegoede well, we do need to clean some stuff up and a new release of Cordova will make the hooks directory go away which I'm happy for. Next week I'll be sitting down with the CSDK team to make more progress. Please let us know if you have any problems by raising issues.