search

CreativeTechGuy / no-bad-alchs

Prevents casting alchemy on items which give less than the GE value
BSD 2-Clause "Simplified" License
1 stars 1 forks source link

Parchment #9

Open Kaljakolmio opened 1 month ago

Kaljakolmio commented 1 month ago

if you have parched avernic defender it still shows when you have hide untradeables on

CreativeTechGuy commented 1 month ago

Ah dang it. Okay so the way I was determining untradeable items is based on their item price here:

https://github.com/CreativeTechGuy/no-bad-alchs/blob/d208a32f5a4b594cce3c56154d8dc2b2060f7496/src/main/java/com/creativetechguy/NoBadAlchsPlugin.java#L201

We'll need to figure out some other way to detect untradeables. If you can find another plugin which correctly identifies parchmented avernic defenders, post a link so I can take a look at how they identify them and we can get this updated.

Kaljakolmio commented 1 month ago

could the (I) in the items name be detected when its imbued?

CreativeTechGuy commented 1 month ago

The untradeable detection is purely based on the item's price as far as RuneLite says. So I'm guessing that despite parchment-ed items still being untradable, they are reported as having a price. The name isn't involved in determining if it's untradeable.