Creatiwity / gatsby-plugin-favicon

UNMAINTAINED - Favicon Gatsby plugin
MIT License
166 stars 27 forks source link

Upgrade for Gatsby v2 (onCreateWebpackConfig/setWebpackConfig) #32

Closed TuckerWhitehouse closed 6 years ago

TuckerWhitehouse commented 6 years ago

As part of the Gatsby v2 upgrade, modifying the webpack config has received a new redux based api: https://next.gatsbyjs.org/docs/migrating-from-v1-to-v2/#change-modifywebpackconfig-to-oncreatewebpackconfig

chasemccoy commented 6 years ago

@Creatiwity can you merge and publish this? I am using Gatsby 2 now and this plugin is broken. This would be a great fix!

janosh commented 6 years ago

Any reason why this PR is not being accepted? Would be great to have v2 compatibility.

julien1619 commented 6 years ago

Thank you for this PR. In fact I was busy and working on a last (big) update for Gatsby v1 but I didn't see that it was already in beta.

I will merge it in a feature branch tomorrow, release a last version on v1 without my current changes to speed everything up and publish this v2-based version shortly after.

janosh commented 6 years ago

@julien1619 Nice! Looking forward to it.

julien1619 commented 6 years ago

So I've merged it after fixing some conflicts, but I can't make it work with Gatsby v2. I can't say the exact error cause. Can you test it @JanoshRiebesell using the branch gatsby-v2 from this repository to see if you reproduce it? Thank you very much!

The error comes from favicons-webpack-plugin not finding webpack/lib/SingleEntryPlugin when building the site with Gatsby. It's the first I'm using Gatsby v2 so I don't know if it's Gatsby not exposing some dependency stuff, or favicons-webpack-plugin using webpack the wrong way, or simply my setup.

To test it you would need to pull this branch locally, and reimport favicons-webpack-plugin in it using the direct git link (a fix is available but not published yet). Thanks again!

julien1619 commented 6 years ago

Ok, so I've found it! Will be releasing this new version very soon with a lot of changes.

janosh commented 6 years ago

@julien1619 That's great! Let me know if I can help write docs for those changes if applicable.

julien1619 commented 6 years ago

Thanks @JanoshRiebesell, the big update is available ;)