Creatiwity / gatsby-plugin-favicon

UNMAINTAINED - Favicon Gatsby plugin
MIT License
166 stars 27 forks source link

html-react-parser dependency pulling old React version #62

Open alessandrojcm opened 5 years ago

alessandrojcm commented 5 years ago

Hi there,

I'm using this plugin on a project, but I'm having this weird issue. You'll see, this plugin depends on html-react-parser on its 0.x.x version; this package in turn depends on react-dom-core@0.1.1 which in turn pulls React version 15.6.2. My project uses the latest React version, so this causes a duplicate module error; with my project failing to run.

Here's the output of yarn why illustrating the problem:

yarn why v1.15.2
[1/4] Why do we have the module "react"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "react@16.8.6"
info Has been hoisted to "react"
info Reasons this module exists
   - Specified in "dependencies"
   - Hoisted from "netlify-cms#react"
   - Hoisted from "background-image-on-load#react"
   - Hoisted from "gatsby#gatsby-cli#react"
   - Hoisted from "netlify-cms#netlify-cms-app#netlify-cms-core#react"
=> Found "gatsby-plugin-favicon#react@15.6.2"
info Reasons this module exists
   - "gatsby-plugin-favicon#html-react-parser#react-dom-core" depends on it
   - Hoisted from "gatsby-plugin-favicon#html-react-parser#react-dom-core#react"