Creatiwity / gatsby-plugin-favicon

UNMAINTAINED - Favicon Gatsby plugin
MIT License
166 stars 27 forks source link

Something went wrong installing the "sharp" module #64

Open robmarshall opened 5 years ago

robmarshall commented 5 years ago

Error: The specified procedure could not be found. \?\C:\projects\runleeds\Run-Leeds-Gatsby\node_modules\favicons\node_modules\sharp\build\Release\sharp.node

It seems that the favicon libary used by https://github.com/Creatiwity/favicons-webpack-plugin is out of date? May not be the issue...

The build is running on Netlify, but not my local host.

metafield commented 5 years ago

Getting the exact same issue here

julien1619 commented 5 years ago

I'll try to release a version this week with updated dependencies. Thanks for the report!Le 19 sept. 2019 18:14, Anthony Sylvester notifications@github.com a écrit :Getting the exact same issue here

—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

kowalski7cc commented 5 years ago

I confirm having the same issue but only with Windows. On WSL or Netlify bulids no issue at all. Tested on Windows and on WSL with Node LTS.

robmarshall commented 5 years ago

I had a look into this but couldn't see exactly what was needed to be changed. Would anyone be able to help? I am trying to use this for a site of mine.

SimeonC commented 5 years ago

I got this when I did npm install on a different machine and then copied the node_modules across to the new machine. Using docker and multiple "machines" in the CI. We fixed this by making sure you build and install on the same type of machine and node version.

julien1619 commented 5 years ago

I looked into this problem and it seems that sharp was updated in others gatsby plugins and it's not compatible with the version we use.

This plugin is based on favicons-webpack-plugin, which is a fork of an inactive library (no new release since a few months), which depends on favicons. favicons is currently well maintained but have not yet updated its sharp version. So it's tricky to keep everything up-to-date.

I'm thinking about rewriting a new major version of my plugin based directly on favicons or sharp to avoid this situation. I only need time or some help.

vitkon commented 5 years ago

I'll second it, update to sharp@0.23.1 is required to use your plugin with the latest Gatsby deps. I had to remove it for now to be up to date with the rest of Gatsby ecosystem.

abumalick commented 5 years ago

@julien1619 it looks like favicons-webpack-plugin got some updates lately: https://github.com/jantimon/favicons-webpack-plugin/releases

Maybe it is not worth rewriting everything.

Here is a quick fix to this issue, that force favicons to use sharp@0.23.1

Add this to package.json

"resolutions": {
    "gatsby-plugin-favicon/favicons-webpack-plugin/favicons/sharp": "0.23.1"
}

ref https://yarnpkg.com/lang/en/docs/selective-version-resolutions/

mathiasha commented 4 years ago

This is still an issue for me. I have to remove this plugin for Gatsby to build. Is anyone working on a fix for this?

julien1619 commented 4 years ago

I've looked into it again and favicons-webpack-plugin was updated lately. But it dropped a key feature needed by gatsby-plugin-favicon : the stats file generation.

This file is used to inject the generated favicons into all HTML pages generated by Gatsby. If I update this dependency, it will fix the Sharp plugin problem but will break the whole thing anyway.

There are multiple options, but every one of them requires time.

I don't know yet which one to choose.

bnbon commented 4 years ago

Any idea which path you plan to take Julien? Thanks