patches/weather: don't use floating point

CreatorDev / LetMeCreateIoT

LetMeCreate library for the PIC32MX clicker

BSD 3-Clause "New" or "Revised" License

5 stars 8 forks source link

patches/weather: don't use floating point #28

Closed malaakso closed 7 years ago

malaakso commented 7 years ago

PIC32MX doesn't have FPU, so it makes sense to perform BME280 compensation calculations using integer math. Accuracy is unaffected.

nikhil-zinjurde-imgtec commented 7 years ago

Sorry for jumping to conclusions, I see all previous PRs raised against "dev". So, changed the base branch back as before Although, my doubt still remains, any use of maintaining 2 branches?

mtusnio commented 7 years ago

@malaakso Sorry about the delay, I haven't had access to any of the clicks until today, I'll do a review and verify the PR as soon as I can!

@nikhil-zinjurde-imgtec Dev is for whatever is done between releases that shouldn't be pulled in, sometimes contains design changes that I would prefer people not checking out until a release have been made. Master is always safe to check out, even if it's ahead of the newest release since it sometimes contains some minor fixes (for CI etc.).

mtusnio commented 7 years ago

Code looks good, unfortunately the only weather click I have access to is not working properly due to I2C issues so I can't properly test it. According to the docs this looks fine though, if any issues pop up due to this change it will need a fix in LMC.