Creators-of-Create / Create

[Forge Mod] Building Tools and Aesthetic Technology
MIT License
2.85k stars 896 forks source link

Rendering issues in multiplayer #1700

Closed Aiife closed 2 years ago

Aiife commented 3 years ago

Some friends of mine made a modpack and started up a server so we could play together, works well for the most part, the only issue we've run into is this here: https://user-images.githubusercontent.com/83099839/120375398-618c9c80-c2e0-11eb-9b9f-8b9bad2a9d03.mp4 This happens 100% of the time, to any contraption that moves blocks. It also only occurs on the server, it works fine in singleplayer

The problem fixes itself if we unload the chunk, but is there anything we can do to actually prevent needing to do that? This happens with 1 other mod we have, so I'm sure the problem isn't coming from create, but I'm hoping I can get some help here

Soringaming commented 3 years ago

Also having this exact issue, but all of the blocks that are moving just vanish, you're able to walk through them like they aren't there too. The only way to fix it is to leave the server and come back, or, place blocks there to force a block update. This alone made me remove the mod from my server, and I don't plan to re-add it until it's fixed tbh. (Willing to give whatever info is necessary to get this fixed)

samdev-7 commented 3 years ago

Do you have optifine in the client modlist? Some Optifine versions mess with collision.

Soringaming commented 3 years ago

I double-checked to make sure, and I don't have it installed. I was really hoping this was gonna be the fix.

Aiife commented 3 years ago

We also don't have it. First thing I thought of

ChiefArug commented 3 years ago

Is immersive portals in the modpack? I have seen it cause some similar issues with it. Could be related to: https://github.com/Creators-of-Create/Create/issues/1602

Aiife commented 3 years ago

No, that isn't in our modpack either.

samdev-7 commented 3 years ago

Can you post the modlist?

Aiife commented 3 years ago

Yeah, I've asked the server owner to put together one for me since we didn't actually have one easy to copy and paste ready. However, in the meantime, I've found this in the logs, I'm not good with this sort of stuff, but I figured posting potentially irrelevant info is better than not posting potentially useful info.

[B#643] [02:39:25.488] [Render thread/FATAL] [concurrent.ThreadTaskExecutor/]: Error executing task on Client java.lang.NullPointerException: null [B#643] at net.minecraft.world.World.func_241211a(World.java:186) ~[?:?] {re:computing_frames,pl:accesstransformer:B,xf:fml:observerlib:coremodmethod,xf:fml:astralsorcery:sun_brightness_server,xf:fml:twilightforest:hitbox,re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,xf:fml:observerlib:coremodmethod,xf:fml:astralsorcery:sun_brightness_server,xf:fml:twilightforest:hitbox,pl:mixin:APP:create.mixins.json:TileWorldHookMixin,pl:mixin:A} [B#643] at net.minecraft.world.World.func_180501_a(World.java:176) ~[?:?] {re:computing_frames,pl:accesstransformer:B,xf:fml:observerlib:coremodmethod,xf:fml:astralsorcery:sun_brightness_server,xf:fml:twilightforest:hitbox,re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,xf:fml:observerlib:coremodmethod,xf:fml:astralsorcery:sun_brightness_server,xf:fml:twilightforest:hitbox,pl:mixin:APP:create.mixins.json:TileWorldHookMixin,pl:mixin:A} [B#643] at net.minecraft.client.network.play.ClientPlayNetHandler.func_243492_a(ClientPlayNetHandler.java:717) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,xf:fml:xaerominimap:xaero_clientplaynethandler_cleanup,xf:fml:xaerominimap:xaero_clientplaynethandler_handlejoingame,xf:fml:xaerominimap:xaero_clientplaynethandler_handlemultiblockchange,xf:fml:xaerominimap:xaero_clientplaynethandler_handlechunkdata,xf:fml:xaerominimap:xaero_clientplaynethandler_handleblockchange,xf:fml:xaerominimap:xaero_clientplaynethandler_handlespawnpoint,xf:fml:xaerominimap:xaero_clientplaynethandlerclass,pl:mixin:APP:randompatches.mixins.json:client.keybindings.ClientPlayNetHandlerMixin,pl:mixin:APP:betterendforge.mixins.json:ClientPlayNetHandlerMixin,pl:mixin:APP:valhelsia_core.mixins.json:client.ClientPlayNetHandlerMixin,pl:mixin:APP:create.mixins.json:NetworkLightUpdateMixin,pl:mixin:A,pl:runtimedistcleaner:A} [B#643] at net.minecraft.network.play.server.SMultiBlockChangePacket.func_244310_a(SourceFile:79) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,xf:fml:xaerominimap:xaero_smultiblockchangepacketclass} [B#643] at net.minecraft.client.network.play.ClientPlayNetHandler.func_147287_a(ClientPlayNetHandler.java:716) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,xf:fml:xaerominimap:xaero_clientplaynethandler_cleanup,xf:fml:xaerominimap:xaero_clientplaynethandler_handlejoingame,xf:fml:xaerominimap:xaero_clientplaynethandler_handlemultiblockchange,xf:fml:xaerominimap:xaero_clientplaynethandler_handlechunkdata,xf:fml:xaerominimap:xaero_clientplaynethandler_handleblockchange,xf:fml:xaerominimap:xaero_clientplaynethandler_handlespawnpoint,xf:fml:xaerominimap:xaero_clientplaynethandlerclass,pl:mixin:APP:randompatches.mixins.json:client.keybindings.ClientPlayNetHandlerMixin,pl:mixin:APP:betterendforge.mixins.json:ClientPlayNetHandlerMixin,pl:mixin:APP:valhelsia_core.mixins.json:client.ClientPlayNetHandlerMixin,pl:mixin:APP:create.mixins.json:NetworkLightUpdateMixin,pl:mixin:A,pl:runtimedistcleaner:A} [B#643] at net.minecraft.network.play.server.SMultiBlockChangePacket.func_148833_a(SourceFile:71) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,xf:fml:xaerominimap:xaero_smultiblockchangepacketclass} [B#643] at net.minecraft.network.play.server.SMultiBlockChangePacket.func_148833_a(SourceFile:15) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,xf:fml:xaerominimap:xaero_smultiblockchangepacketclass} [B#643] at net.minecraft.network.PacketThreadUtil.func_225383_a(SourceFile:21) ~[?:?] {re:mixin,re:classloading} [B#643] at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213166_h(SourceFile:144) ~[?:?] {re:computing_frames,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B} [B#643] at net.minecraft.util.concurrent.RecursiveEventLoop.func_213166_h(SourceFile:23) ~[?:?] {re:computing_frames,re:mixin,re:classloading} [B#643] at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213168_p(SourceFile:118) ~[?:?] {re:computing_frames,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B} [B#643] at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213160_bf(SourceFile:103) ~[?:?] {re:computing_frames,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B} [B#643] at net.minecraft.client.Minecraft.func_195542_b(Minecraft.java:947) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,xf:fml:traylauncher:loadingHookCoremod,pl:mixin:APP:randompatches.mixins.json:client.MinecraftMixin,pl:mixin:APP:betterendforge.mixins.json:MinecraftMixin,pl:mixin:APP:immersiveengineering.mixins.json:accessors.client.MinecraftAccess,pl:mixin:APP:kubejs-common.mixins.json:MinecraftMixin,pl:mixin:APP:assets/botania/botania.mixins.json:AccessorMinecraft,pl:mixin:APP:create.mixins.json:ShaderCloseMixin,pl:mixin:A,pl:runtimedistcleaner:A} [B#643] at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:607) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,xf:fml:traylauncher:loadingHookCoremod,pl:mixin:APP:randompatches.mixins.json:client.MinecraftMixin,pl:mixin:APP:betterendforge.mixins.json:MinecraftMixin,pl:mixin:APP:immersiveengineering.mixins.json:accessors.client.MinecraftAccess,pl:mixin:APP:kubejs-common.mixins.json:MinecraftMixin,pl:mixin:APP:assets/botania/botania.mixins.json:AccessorMinecraft,pl:mixin:APP:create.mixins.json:ShaderCloseMixin,pl:mixin:A,pl:runtimedistcleaner:A} [B#643] at net.minecraft.client.main.Main.main(Main.java:184) ~[minecraft.jar:?] {re:classloading,pl:runtimedistcleaner:A} [B#643] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_271] {} [B#643] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_271] {} [B#643] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_271] {} [B#643] at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_271] {} [B#643] at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:51) ~[forge-1.16.5-36.1.23-launcher.jar:36.1] {} [B#643] at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.0.9.jar:?] {} [B#643] at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.0.9.jar:?] {} [B#643] at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.0.9.jar:?] {} [B#643] at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [modlauncher-8.0.9.jar:?] {re:classloading} [B#643] at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [modlauncher-8.0.9.jar:?] {re:classloading} [B#643] at io.github.zekerzhayard.forgewrapper.installer.Main.main(Main.java:50) [ForgeWrapper-1.4.2.jar:?] {} [B#643]

Aiife commented 3 years ago

Server owner made the modlist, seems unconventional but here ya go https://drive.google.com/file/d/1TdTBnm8zOf5Y09ivS6CBjrrgoHuGVW-7/view?usp=sharing

ChiefArug commented 3 years ago

That file is 243 MB, are you sure it is a mod list? Google docs refuses to open it and a file that large seems fishy to me. You could export the pack as a .zip on CurseForge (through the three dot menu next to the play button), then upload that to GitHub (just drag and drop into the comment box!). You could also upload a full crash report as that usually has a full modlist at the end of it. (Drag and drop into GitHub)

Aiife commented 3 years ago

Totally understand, apparently what they did was just shove all the mod files into a google doc, here's a crash report, hopefully this helps https://drive.google.com/file/d/12Swbt6fetFqZWqYHR4Z6PcpX--N7Qxte/view?usp=sharing

sdarkwell commented 3 years ago

Hello Create Team,

I am having the same as @Aiife. I too am using neither Optifine nor Immersive Portals. Additionally, these mods (and a number of additional Client-side mods) work without issue in Single Player, but not on a local server).

Any assistance with locating the source of this issues would be greatly appreciated.

Please let me know if any additional information may be useful, and/or if you would prefer I create a separate issue for tracking purposes!

Thank you in advance and be well. :)

My mod list:

sdarkwell commented 3 years ago

Hello Create Team,

We've found that removing Supplementaries may have have fixed the issues?

However, when creating a new server with just Create and Supplimentaries, we aren't able to recreate the issue. Also, using different versions of Supplimentaries (including the newest version, and the prior version that is used by the Valhelsia 3 modpack) does not appear to fix the issue.

Additionally, I see that @Aiife did not have Supplementaries on their mod list.

So, we're still a bit stumped, and would prefer not to have to disable Supplimentaries, as it's a well-liked mod, but that is our only clue so far.

Hopefully this goes some way toward helping to diagnose the issue.

github-actions[bot] commented 2 years ago

This issue has been marked as stale because it has been inactive for 3 weeks. It will be closed if it remains inactive for another 3 weeks.

github-actions[bot] commented 2 years ago

This issue has been closed since it has been inactive for 3 weeks since it was marked as stale.