search

Creators-of-Create / Create

[Forge Mod] Building Tools and Aesthetic Technology
MIT License
2.93k stars 907 forks source link

Major Lighting Bug On Server #186

Closed xRB34 closed 4 years ago

xRB34 commented 4 years ago

We keep getting these severe lighting bugs on our server. These lighting bugs keep showing up. The lighting level is zero during the day in theses areas. They are happeneing around where conveyer belts are and gears.

2020-04-01_16 29 45 2020-04-01_16 29 31

CrudeAustin commented 4 years ago

Commenting for further confirmation on this bug.

This bug also affected me this morning when teleporting back to my manor after travelling thousands of blocks away, just one chunk turned completely pitch black- the same exact chunk where a bunch of cogs, shafts, fans, and an crusher was. This issue isn't just visual too, it starts counting chunks as unlit and allows hostile mobs to spawn.

2020-04-01_17 44 00 2020-04-01_15 14 18

After some testing, removing the entire setup in that exact chunk, travelling far enough, and then teleporting back home seems to have stopped the bug. I'm still uncertain if this is actually create causing it though, since one test may not be enough.

xRB34 commented 4 years ago

Here are some more screenshots. This is only happening around create blocks and items. 2020-04-01_18 27 02 2020-04-01_18 27 52

CrudeAustin commented 4 years ago

I may have narrowed down the issue after testing some suspicions. seems double-block adjustable crates may be completely breaking the chunk lighting it's sitting on, after a bit of testing in a creative flatworld.

First test: teleporting to an lit room with 1-block sized adjustable crates and some fans + cogs. 2020-04-01_18 32 10

Second test: this time with horizonal 2-block adjustable crates. lighting is completely busted. 2020-04-01_18 30 41

Third test: now with vertical 2-block adjustable crates. same result. 2020-04-01_18 33 17

I'm not sure if this may help as a workaround; remove your double-block adjustable crates and replace them with something else then fix the lighting by spamming torches. If the issue persists then other things may be causing the issue too, not just 2-block adjustable crates.

xRB34 commented 4 years ago

Thanks for the tests my homie CrudeAustin you are a mfing g.

Vaelzan commented 4 years ago

Botania had a similar issue. I'm linking it because the explanation down the bottom of the thread seems like it may make sense here too. https://github.com/Vazkii/Botania/issues/3140

simibubi commented 4 years ago

Can confirm that crates do problematic things in their save method, causing both chunks lighting and data to disappear. If anyone finds out about other components causing this, please report it to us. With all the we know about this bug, we only found the adjustable crate to expose the required behaviour in code.

CrudeAustin commented 4 years ago

Okay, I don't think that's the end of this bug. While the crates have been an isolated issue within the mod itself, seems certain tile entities from other mods MAY possibly be also causing the bug to appear when placed in a chunk with certain rotational components from Create.

After a long debugging process over on the discord's bug reports channel, turns out Refined Storage does NOT like the mod- seemingly looking like a major incompatibility issue somewhat.

I've managed to reproduce the bug again with an RS setup and three lone shafts + one motor rotating them below in the screenshot here: 2020-04-09_22 40 41 Prior to triggering this, I tried this with an unpowered millstone in that chunk. and another instance, only the RS system itself alone. the bug did not occur in either of those instances. I still do not know if this issue is isolated to Refined Storage + Create only either, since I have not tested other mods with this reproduction method yet.

Vaelzan commented 4 years ago

There are multiple chunks being impacted on my server without any crates, but it is hard to be certain exactly what is causing the issue. One chunk was being impacted when it was a fairly basic water mill, shafts, cogwheels, grinding wheel setup (being fed by an extractor, and with an Essentials High-Throughput Hopper collecting the drops - essentially just a fast hopper).

There was nothing really abnormal in there, but the player impacted was loading and unloading chunks pretty regularly via a nearby waystone teleporter. Unfortunately I can't get a screenshot of how it was setup when the issue first occurred, as it has since been replaced with something different.

Another player has a far more complicated setup in the impacted chunk, so I can't even begin to narrow down what could be causing the issue there, but I can also confirm no crates were involved in the chunk.

juliand665 commented 4 years ago

For what it's worth, 0.2.2b seems to have fixed our issues with RS and Create stuff in the same chunk—looks like 3c0b55ac1d74c00c7424718f72414197745f6c33 did it.