search

Creators-of-Create / Create

[Forge Mod] Building Tools and Aesthetic Technology
MIT License
2.9k stars 908 forks source link

Create + Terralith 2.0 = small bug! (NoCrashServeur or client) Just bug ! #2636

Closed SpelliCosta closed 2 years ago

SpelliCosta commented 2 years ago

Describe the Bug

Hello, I have just declared a bug between your mod create and that of terralith 2.0.

there are no errors in the server logs, just that a classic lumber farm that uses saws works but breaks tree inches. And its only when the terralith 2.0 mod is installed without its working fine. ^^

Thank you for your mod it's great keep it up.

spelli

Reproduction Steps

classic lumber farm

Expected Result

Saws break thumbs of trees instead of going their way and only break wood

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

windows 10

Mod Version

0.4.0b

Minecraft Version

1.18.1

Forge Version

2 versions testing 39.0.17 and 39.0.36

Other Mods

Terralith 2.0

Additional Context

No response

GobbleyDuck commented 2 years ago

huh... here I was about to report this bug. yeah, I tested this on my computer and server, they both do not like saplings either

copygirl commented 2 years ago

Could it be that the Terralith datapack's trees are sometimes not made with natural leaves, but instead use player-placed version leaves (that do not despawn when disconnected from a block)? It could be that Create checks for the existence of such leaves to determine the general size of trees, such as some other mods do I believe. I have noticed some trees from Terralith spawned during world-gen do not have their leaves despawn even when all logs are removed.

HumanMint commented 2 years ago

I found the issue. It had something to do with Terralith's implementation of how saplings work. image

I made a manual fix that removes that leaves tag which I feel like should only affect manual custom tree growth and not natural tree growth in the world generation. I might be wrong because I am not a dev whatsoever.

https://github.com/HumanMint/terralith-sapling-mint-patch

Here is a video on how to do it (because you shouldn't trust random people's patches on official mods/datapacks) https://youtu.be/qUQnUybcJ6I

Text instructions

  1. unzip .jar/.zip of terralith 2.0
  2. go to data > minecraft > tags > blocks > leaves.json
  3. open as a text document and delete the line that contains "#saplings"
  4. save and re-zip everything (and rename .zip to .jar if editing the mod version)
  5. technically only required server-side but you would want it as well for singleplayer testing worlds
  6. profit

TL;DR Create mod isn't responsible for this issue

simibubi commented 2 years ago

Thanks for reporting. Fixed in Patch D