Creators-of-Create / Create

[Forge Mod] Building Tools and Aesthetic Technology
MIT License
2.88k stars 900 forks source link

Wrench scrolling interactions are hardcoded to check for the create wrench #2876

Open RCXcrafter opened 2 years ago

RCXcrafter commented 2 years ago

Describe the Suggestion

I would like to suggest a hook for addons to check if the current itemstack is valid for scrolling interactions similar to the one that currently exists for the goggles: https://github.com/Creators-of-Create/Create/blob/mc1.18/dev/src/main/java/com/simibubi/create/content/contraptions/goggles/GogglesItem.java

Screenshots and Videos

No response

Additional Context

I'm making a mod that adds a tinkers construct wrench tool and I have added a modifier that allows my wrench to take on the functionality of the create wrench to turn it into an omni-wrench of sorts. Currently my wrench can't configure machines with scroll interactions since these are hardcoded to check for the create wrench: https://github.com/Creators-of-Create/Create/blob/mc1.18/dev/src/main/java/com/simibubi/create/foundation/tileEntity/behaviour/scrollvalue/ScrollValueHandler.java#L49

RCXcrafter commented 2 months ago

Was this issue closed becasue the requested hook was added or because it will not be added?