search

Creators-of-Create / Create

[Forge Mod] Building Tools and Aesthetic Technology
MIT License
2.72k stars 877 forks source link

Deny list filter on single tunnel with multiple outputs breaks the routing of the tunnel #3139

Open weegeeluigi opened 2 years ago

weegeeluigi commented 2 years ago

Describe the Bug

Posted on fabric, Tropheus says Forge works the same way so reposting here as I believe this is a bug.

A deny filter on a single tunnel with multiple outputs stops the tunnel from applying whatever filtering config is applied to it. It appears in single tunnel setups, the deny filter will double as an implicit allow for every other item. In other words, the deny filter will work correctly, but it will also behind the scenes appear to act as an allow for every other item(s) not in the deny filter, rendering the other tunnel outputs broken.

Attached screenshot shows the setup. The tunnel is set to forced round robin. The side with the filter is a deny filter with only coal. Coal won't go on that belt. It will go straight, as it should. Place any other item on the belt though, and the tunnel will always output on the filter side where coal is denied. It doesn't not alternate between that side and going straight, like it should. It will only do so if you place an allow filter on the other side.

Reproduction Steps

1.Setup a belt system where you can place a tunnel for more than 1 output.

  1. Place a tunnel where you want to split the output.
  2. Add a deny filter to one side (let's say, coal)
  3. Set the filter to forced round robin
  4. Coal never goes out the deny filter side (correct) and only the other output
  5. Every other item not in the deny filter (so, not coal) will only go out the deny filter side only. Round robin doesn't work, even if the output is valid. The round robin fails. The only way to get the round robin to work is to add an allow filter to the other output explicitly

Expected Result

Coal or whatever denied item(s) don't go down that route, but other valid outputs function and output according to their filters or lack of filters.

Screenshots and Videos

2022-06-22_17 04 45

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.4.1

Minecraft Version

1.18.2

Forge Version

Not using forge

Other Mods

No response

Additional Context

No response

weegeeluigi commented 2 years ago

Installed Forge since I haven't heard anything. Patch C of 0.5 with Forge 40.1.68 and most definitely still bugged as described above.