Creators-of-Create / Create

[Forge Mod] Building Tools and Aesthetic Technology
MIT License
2.94k stars 907 forks source link

NBT tag that was too big #3411

Closed FalseMSP closed 3 weeks ago

FalseMSP commented 2 years ago

Describe the Bug

I built a auto miner to get resources but then when i picked up the drill, it kicked me with an error, and now i am banned from my own server B)

Reproduction Steps

  1. Make an auto mining drill
  2. Mine for a while
  3. If it is big enough, when you pick it up it will kick you from the server ...

Expected Result

I should have the item lol

Screenshots and Videos

image

Crash Report or Log

no crash, just kick

Operating System

Windows 11

Mod Version

0.5.0c

Minecraft Version

1.18.2

Forge Version

40.1.60

Other Mods

image

Additional Context

Just a server, will wipe my playerdata so its not a big deal, but should be resolved nonetheless

Jmooroof commented 2 years ago

This isn't a bug with Create.

Minecraft will kick you if you have too much data. When you play modded Minecraft, make sure you don't have too much data in your inventory.

(don't ask me anything about Create. I am not a developer)

FalseMSP commented 2 years ago

yea i realize that, i just assumed that they should do something to make sure the minecart contraption never pushes that limit which is y i put it here

MrRedRhino commented 2 years ago

3001

mcspacecash commented 1 year ago

Is there any way to search in NBT Explorer* for that contraption and edit it to get it down to a size that won't boot the player? I unfortunately didn't backup my single player world and now can't get in. I'd rather not start over. If I can find this contraption and edit it, hopefully I can load in and correct it.

I believe where I went wrong was too many chests each with a single block in each cell. I was using that was a way to filter the blocks I would collect (ie double chests of only cobble, dirt, gravel, etc.).

*When I try to search "contraption" in NBTExplorer the program freezes and then crashes. I'm wondering if there's a specific name/value I could query to find a contraption.

FalseMSP commented 1 year ago

Hey ik this is old but here's my weird solutions...

if its in your inventory than just look thorugh ur inventory and there are some tags that you can delete if its still placed I just found that /kill works well in console (This is on a server, idk if it works on singleplayer) IDK how helpful this is 🤷

mcspacecash commented 1 year ago

It's not in my inventory, unfortunately. It happened the second I flipped the lever to turn it from a contraption in the world to an entity. I'm assuming that when I did that it turned into a single entity with too many NBT tags. Unfortunately, I believe I would have to find the chunk where that entity is, but I don't know how/where. If I knew what to search for in NBT Explorer and if NBT Explorer wouldn't crash when searching I could probably do that.. :-(

TankMissile commented 1 year ago

Same thing happened on my server. It would be nice if there was some safeguard against it, such as an error notice and preventing you from creating the entity or picking it up when the NBT is too big. It's very easy to nuke a world unexpectedly.

UtherForgermann commented 1 year ago

I experienced the same issue. I had multiple contraptions with chests (possibly full chests) in my inventory. As I use gravestones datapack from Vanilla Tweaks upon death I received same "to big NBT file" error. My suggestion for the Create side of things would be to limit the amount och containers that could be added to a contraption so it could not get too big as I assume it was it's inventory combined with the contraption itself that was responsible for so big NBT size

muriplz commented 1 year ago

i made a client side mod that can solve it, and also XLPackets works to solve it (i think). Here is the mod in question https://modrinth.com/mod/create-big-contraptions Would love to see a fix in base Create though!

LaidBackSloth commented 1 year ago

For me, neither CreateBigContraptions nor XLPackets did work, but https://www.curseforge.com/minecraft/mc-mods/packet-fixer did

PiTheGuy commented 1 year ago

Create already has a check that's supposed to prevent this, but it clearly doesn't work every time

KakashoLin commented 7 months ago

Server seemed to have issues after using Create's Item Vault and hooking chests to it. Getting the exact error message above.

muriplz commented 7 months ago

Server seemed to have issues after using Create's Item Vault and hooking chests to it. Getting the exact error message above.

not sure if you will find it useful, but I made a mod that fixes this client side, called Create: Big Contraptions. XLPackets I think also fixes this issue

DereC4 commented 7 months ago

Happening on my side too; anyone have luck using nbt explorer to fix this?

IThundxr commented 3 weeks ago

There's a check that prevents this