Creators-of-Create / Create

[Forge Mod] Building Tools and Aesthetic Technology
MIT License
2.89k stars 907 forks source link

Schematicannon places slabs from "Just Vertical Slabs" with missing data #3424

Closed IdrisQe closed 5 months ago

IdrisQe commented 2 years ago

Describe the Bug

The mod "Just Vertical Slabs" adds vertical slabs generated from every slab in the game, using only two block IDs, by using some sort of extra data that isn't kept in the blockstate as far as I can tell. One issue that arises from this is that the schematicannon doesn't seem to understand this extra data.

Holding a schematic to view a preview works fine, and all slabs show correctly, but loading the same schematic into a cannon, even with a creative crate next to it, will cause any JVS slabs placed by the cannon to have the default no-data oak texture they use as a fallback, and "corner vertical slabs" seem to break entirely, rendering a hole in the world instead of a texture and with the wrong hitbox. They seem to not be placed with the extra data they're supposed to have.

Reproduction Steps

  1. Build something using Just Vertical Slabs' Vertical Slabs
  2. Create a Schematic of the area using Schematic and Quill
  3. Place a Schematicannon with a Creative Crate
  4. Active the Schematicannon

Expected Result

The expected result would be for the schematicannon to place the block as copied into the schematic.

Screenshots and Videos

The scene as it should be, using cobbled deepslate vertical slabs and plating vertical slabs (plating from Architect's Palette mod): 2022-07-18_14 59 32

The scene partially recreated by a schematicannon, the slabs having lost information about what block they're supposed to be copying the properties of: 2022-07-18_15 02 30

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.5.0c

Minecraft Version

1.18.2

Forge Version

40.1.53

Other Mods

Mod List:

additionaladditions-4.0.5.jar alexsmobs-1.18.6.jar alloyed-1.18.2-v1.4b.jar another_furniture-forge-1.1.2-1.18.2.jar appleskin-forge-mc1.18-2.4.0.jar archers_paradox-1.18.2-1.6.1.6.jar Architects-Palette-1.18.2-1.2.0.jar architectury-4.5.76-forge.jar AttributeFix-Forge-1.18.2-14.0.2.jar AxesAreWeapons-1.5.2-forge-1.18.2.jar backpacked-2.1.8-1.18.2.jar balm-3.1.0+0.jar bestylewither-forge-1.18.2-1.2.jar BetterAdvancements-1.18.1-0.1.2.122.jar betterbiomeblend-1.18.2-1.3.5-forge.jar betterflight-forge-1.18-1.0.0.jar BetterThirdPerson-Forge-1.18.2-1.8.1.jar bigbrain-1.5.3.jar Bookshelf-Forge-1.18.2-13.2.36.jar BrewinAndChewin-1.18.2-1.0.1.jar caelus-forge-1.18.1-3.0.0.2.jar chalk-1.18.2-1.2.1.jar citadel-1.11.3-1.18.2.jar cleancut-mc1.18.2-4.0-forge.jar clear-skies-forge-mc118-2.0.92.jar cloth-config-6.2.62-forge.jar Clumps-forge-1.18.2-8.0.0+10.jar CNB-1.18.2-1.3.2.jar cofh_core-1.18.2-1.6.4.21.jar collective-1.18.2-4.28.jar comforts-forge-1.18.2-5.0.0.4.jar Companion-1.18.2-forge-2.1.0.jar corpse-1.18.2-1.0.2.jar create-mc1.18.2_v0.5.0c.jar createaddition-1.18.2-20220715a.jar createdeco-1.2.8-1.18.2.jar curios-forge-1.18.2-5.0.7.1.jar curiouselytra-forge-1.18.1-5.0.1.0.jar customizableelytra-1.18.2-1.6.5.jar cyanide-forge-1.18.2-2.1.1.jar DamageTilt-1.18-forge-0.1.1.jar darkness-forge-mc118-2.0.91.jar debugify-1.11.0-forge-1.18.2.jar Decorative+Blocks-forge-1.18.2-2.1.0.jar domesticationinnovation-1.4.2-1.18.2.jar doubledoors_1.18.2-3.3.jar Durability101-forge-1.18-0.0.4.jar DynamicSurroundings-5.0.0.4.jar EasyMagic-v3.3.0-1.18.2-Forge.jar ecologics-forge-1.18.2-1.7.3.jar elytrautilities-forge-1.0.0+1.18.2.jar EnchantmentDescriptions-Forge-1.18.2-10.0.4.jar EnigmaticLegacy-2.24.1.jar ensorcellation-1.18.2-1.6.1.8.jar entityculling-forge-mc1.18-1.5.1.jar everycomp-1.18.2-1.5.9.jar FarmersDelight-1.18.2-1.1.2.jar FarmersRespite-1.18.2-1.3.0.jar FastLeafDecay-28.jar Fastload-Reforged-1.1.5+1.18.2.jar feature_nbt_deadlock_be_gone_forge-2.0.0+1.18.2.jar ferritecore-4.2.1-forge.jar fiow-18.2.0.jar flywheel-forge-1.18-0.6.4.jar geckolib-forge-1.18-3.0.28.jar goprone-1.18.2-1.7.0.jar grappling_hook_mod-1.18.2-v13.jar guardvillagers-1.18.2.1.4.3.jar HarderNaturalHealing-1.18.1-1.39.0.11.jar horsestandstill-1.18-1.0.2.jar infernal-expansion-1.18.2-2.5.0.jar inventorysorter-1.18-19.0.0.jar inventorytotem_1.18.2-1.6.jar itemstitchingfix-1.18.1-2.1.jar justverticalslabs-1.18.2-3.2.0.1-forge.jar Kiwi-1.18.2-forge-6.1.2.jar lazydfu-1.0-1.18+.jar letthemgrow-1.18-1.0.0.jar light-overlay-6.0.5-forge.jar MaxHealthFix-Forge-1.18.2-5.0.1.jar mcw-doors-1.0.6-mc1.18.2.jar mcw-fences-1.0.5-mc1.18.2.jar mcw-trapdoors-1.0.6-mc1.18.2.jar MouseTweaks-forge-mc1.18-2.21.jar nametagtweaks_1.18.2-1.8.jar naturalist-forge-1.0.4-1.18.2.jar NethersDelight-1.18.2-2.2.0.jar notenoughanimations-forge-1.6.0-mc1.18.2.jar no_nv_flash-1.18.2-1.4.0.2.jar Oh_The_Biomes_You'll_Go-forge-1.18.2-1.4.2.jar Patchouli-1.18.2-71.1.jar PickUpNotifier-v3.2.0-1.18.2-Forge.jar Placebo-1.18.2-6.4.1.jar PuzzlesLib-v3.3.5-1.18.2-Forge.jar radon-0.8.1.jar redstonepen-1.18.2-1.0.10.jar repurposed_structures_forge-5.1.14+1.18.2.jar respawningshulkers_1.18.2-1.7.jar responsiveshields-2.1-mc1.17-18-19.x.jar RoughlyEnoughItems-8.3.502.jar RoughlyEnoughItems-jei-internals-workaround-8.3.510.jar rubidium-0.5.2a.jar rubidium_extras-1.18.2_v1.3.1.jar selene-1.18.2-1.17.9.jar smoothboot-mc1.18.2-1.0.0.jar smoothchunk-1.18.2-1.9.jar snowundertrees-1.18.2-1.2.1.jar sootychimneys-0.5.1.jar StylishEffects-v3.1.0-1.18.2-Forge.jar supersaturation-1.18.2-3.0.3.jar supplementaries-1.18.2-1.4.8.jar TaxFreeLevels-1.3.1-forge-1.18.1.jar TerraBlender-forge-1.18.2-1.1.0.102.jar ToastControl-1.18.2-6.0.2.jar treeharvester_1.18.2-5.1.jar villagernames_1.18.2-3.5.jar VTweaks-1.18.2-3.6.3.jar waystones-forge-1.18.2-10.1.0.jar weakerspiderwebs_1.18.2-2.1.jar windowlogging-mc1.18.2_v0.0.9.jar XaerosWorldMap_1.25.1_Forge_1.18.2.jar Xaeros_Minimap_22.11.1_Forge_1.18.2.jar YungsApi-1.18.2-Forge-2.0.8.jar YungsBetterDesertTemples-1.18.2-Forge-1.2.jar YungsBetterDungeons-1.18.2-Forge-2.1.0.jar YungsBetterMineshafts-1.18.2-Forge-2.2.jar YungsBetterStrongholds-1.18.2-Forge-2.1.1.jar YungsBetterWitchHuts-1.18.2-Forge-1.0.1.jar YungsBridges-1.18.2-Forge-2.1.0.jar YungsExtras-1.18.2-Forge-2.1.0.jar

Additional Context

No response

IThundxr commented 5 months ago

if the data is kept in nbt then the more author for the slabs your using needs to tag them with create:safe_nbt (block tag)

IdrisQe commented 5 months ago

I haven't used that instance or mod in years, but thank you, I'll keep that in mind for future reference. I assume I can also add blocks to that tag via datapacks if a mod author hasn't done it themself?