Open copygirl opened 2 years ago
I gave this another thought. It's unlikely you will get to a version 0.5.10a
or so. Perhaps you could go in and change the version number on Modrinth back to the old format for the sake of compatibility? Just for the time being, until you adopt a new format for the next major Minecraft version.
Interesting yeah, the versioning is off and this should definitely be changed, i've left a message for other's to look at so this can be fixed sometime soon
For lack of a better tag at the moment im gonna dropped confirmed on this so i don't forget to check back on this later
packwiz uses the version number field on Modrinth, parsing it as SemVer, to compare which version it should consider newer when updating or initially adding a mod to a modpack. You appear to have recently changed the format of the version which breaks, as
1.18.2-0.5.0c
is considered "greater" (or "newer") than1.18.2-0.5.0.d
, as per SemVer specification ("Numeric identifiers always have lower precedence than non-numeric identifiers", and0c
is non-numeric).It wouldn't be advisable for packwiz to just go by timestamp, because versions could be uploaded out of order. This could happen for example happen when older, already existing versions of a mod are uploaded to Modrinth by the author.
I'd say the new "format" is better than the previous, since the old one would run into issues if you get into multi-digit territory. So it just is the way it is now. But I do want to note that it would be advisable to move to Semantic Versioning fully:
1.18.2
would be the version, and0.5.0.d
the pre-release identifier. Therefore, on Modrinth, leave out the Minecraft version in the version number field, as that's already available as part of the metadata there. You can of course still include it in the.jar
file name.0.5
releases could just as well have been labelled0.5.0
,0.5.1
,0.5.2
and so on. There is also no shame in using a positive major version even if you don't consider the mod near feature completion. Major version changes suggest breaking changes, which you've already gone through.0.5.0-d
. Though note that thed
here is a "pre-release" section. Usually, one would denote pre-release for example with0.5.0-alpha.1
,0.5.0-beta.1
,0.5.0-pre.1
or0.5.0-rc.1
, before moving to a stable version0.5.0
.See also: packwiz/packwiz#149
Thank you for your work. :green_heart: Sincerely, an ex-modder, SemVer advocate, and writer of a SemVer parsing library.