Closed Partonetrain closed 6 days ago
I'm getting an identical crash (client-side only) in Minecraft 1.19.2, running Forge 43.2.3 using create-1.19.2-0.5.0.i
, EnderStorage-1.19.2-2.10.1.181-universal
, and jei-1.19.2-forge-11.5.2.1007
After investigating, the issue occurs because EnderStorage's ReColourRecipe
(the dynamic recipe to change the color of chests, tanks and pouches) reports being 3x3 but its actual ingredient list contains only one element.
A quick fix from Create's side would be to always check if the slot index is in range here: https://github.com/Creators-of-Create/Create/blob/40f96b0038a91de7c50eb1ead0c4d4477000dab4/src/main/java/com/simibubi/create/compat/jei/category/MechanicalCraftingCategory.java#L103-L105
This fixes the crash, but I think that fundamentally, "special" recipes should never be displayed in JEI, as it's already the case for the normal crafting table and the game's vanilla recipe book. This should probably done around here https://github.com/Creators-of-Create/Create/blob/40f96b0038a91de7c50eb1ead0c4d4477000dab4/src/main/java/com/simibubi/create/compat/jei/CreateJEI.java#L289-L290
For instance:
.addTypedRecipesIf(() -> RecipeType.CRAFTING, recipe -> recipe instanceof IShapedRecipe<?>
&& !AllRecipeTypes.shouldIgnoreInAutomation(recipe)
&& !(recipe instanceof CraftingRecipe craftingRecipe && recipe.isSpecial()))
I tested the above fix and it works, but this may obviously come with disadvantages as it removes some recipes from JEI. I can send a PR for that.
I was bewildered by this error too until I searched for the same issue and encountered this. Good to know there's already a fix in the works, potentially.
confirmed also in 1.19.2 latest versions
confirmed on 1.16.5 on MultiMC with the entire "create above and beyond" modpack, at least according to this: -- JEI render details -- Details: Unique Id (for Blacklist): enderstorage:ender_tank Ingredient Type: class net.minecraft.item.ItemStack Error Info: 1 ender_tank enderstorage:ender_tank Filter Text: Edit Mode Enabled: false Debug Mode Enabled: false
Though I played with two people who did not crash.
edit: I found that you can blacklist the items from appearing by going to your MC folder and going: config->jei->blacklist.cfg Just a temporary solution though.
Unsupported Minecraft Version: Unsupported Minecraft versions no longer receive Create updates. Please check the supported Minecraft versions. If you encounter this issue on a supported Minecraft version, feel free to open a new issue. Thanks!
Outdated Create Version: Since you are using an outdated Create version, please update to the latest version as it may resolve your issue. If this issue persists after updating Create, feel free to open a new issue. Thanks!
This issue is absolutely NOT fixed yet in release for Minecraft 1.20.1.
It's been fixed by this commit: https://github.com/Creators-of-Create/Create/commit/00e919b6c7d13065e394561410dab8873091e5cf
But this commit isn't in the current release as of the time of this posting. Please don't auto-close issues that aren't resolved yet...
This issue is absolutely NOT fixed yet in release for Minecraft 1.20.1.
It's been fixed by this commit: 00e919b
But this commit isn't in the current release as of the time of this posting. Please don't auto-close issues that aren't resolved yet...
That commit is apart of 0.5.1.g/h/i
I saw the release on Curseforge just now; I jumped the gun. Sorry about that.
Describe the Bug
When trying to render(?) EnderStorage recipes with the Mechanical Crafter, the game crashes. I assume this is because of the EnderStorage's custom RecipeTypes (enderstorage:create_recipe, enderstorage:recolour_recipe).
Stacktrace (full log attached):
Reproduction Steps
Expected Result
Not sure exactly because I'm not sure what recipetype is crashing, but ideally it should catch the exception instead of crashing
Screenshots and Videos
No response
Crash Report or Log
https://gist.github.com/Partonetrain/6194ae12fc339594cf5ba8278268e3bf
Operating System
Windows 10
Mod Version
0.5.0e
Minecraft Version
1.18.2
Forge Version
40.1.84
Other Mods
No response
Additional Context
No response