Creators-of-Create / Create

[Forge Mod] Building Tools and Aesthetic Technology
MIT License
2.94k stars 908 forks source link

Builder's tea doesn't grant haste effect when dripping out of a pipe #4559

Open unofficial-fish opened 1 year ago

unofficial-fish commented 1 year ago

Describe the Bug

When you drink builder's tea, it grants you Haste. When potions drip out of the end of a pipe on to an entity, they grant their potion effect. This does not extend to builder's tea. When builder's tea drips out of a pipe, it should grant Haste, and possibly saturation/food bars as well.

Reproduction Steps

  1. Build a pipe system that pumps out Builder's Tea into the world, such that particles are flying out of the open pipe.
  2. Stand under the stream of particles.
  3. Observe that you do not obtain Haste.

Expected Result

I expect to gain the Haste effect, and possibly some hunger bars.

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.5.0i

Minecraft Version

1.19.2

Forge Version

43.2.0

Other Mods

No response

Additional Context

No response

unofficial-fish commented 1 year ago

I'm closing this as a fix has been merged into the main branch

unofficial-fish commented 10 months ago

Reopening this, since the effect doesn't last for the correct amount of time. If you have 8 minute night vision potion, for instance, dripping on to a player, the effect will last for 8 minutes. If you have builder's tea dripping on to you, you will now get the effect, but only for 1 second or so.