search

Creators-of-Create / Create

[Forge Mod] Building Tools and Aesthetic Technology
MIT License
2.93k stars 907 forks source link

Gantry Contraption crashing (Server side) #4560

Open Lucasmellof opened 1 year ago

Lucasmellof commented 1 year ago

Describe the Bug

The method GantryContraptionEntity#applyLocalTransforms is being called on the server side, this shouldn't happen.

Reproduction Steps

  1. Create a gantry contraption.

Expected Result

Not to crash

Screenshots and Videos

No response

Crash Report or Log

crash-2023-03-13_16.45.48-server.txt

Operating System

Ubuntu and Windows 11

Mod Version

0.5.0i

Minecraft Version

1.19.2

Forge Version

43.2.0

Other Mods

No response

Additional Context

It's an easy fix, annotate the method with @OnlyIn(Dist.CLIENT), just like its parent class.

chewieblue commented 1 year ago

Hey! I'm trying to figure out where exactly this method is. Can you post where exactly this method is so I can make the fix?

Lucasmellof commented 1 year ago

Here: https://github.com/Creators-of-Create/Create/blob/c2977bbffff4c1b1b3cfb2311fdd42e51b05749c/src/main/java/com/simibubi/create/content/contraptions/components/structureMovement/gantry/GantryContraptionEntity.java#L179

I didn't fix it before, because I didn't have time. But you need to annotate the method with @OnlyIn(Dist.CLIENT)

Lucasmellof commented 1 year ago

This issue is happening at: #4553, #4404, #4304