Creators-of-Create / Create

[Forge Mod] Building Tools and Aesthetic Technology
MIT License
2.84k stars 897 forks source link

Crash during ponder #4593

Closed troyheady2 closed 4 months ago

troyheady2 commented 1 year ago

Describe the Bug

client crashed during ponder of mixer

running AOF6+ few extra mods crash error

The game crashed whilst ticking screen Error: java.lang.ClassCastException: class com.simibubi.create.foundation.ponder.PonderWorld cannot be cast to class net.minecraft.class_2791 (com.simibubi.create.foundation.ponder.PonderWorld and net.minecraft.class_2791 are in unnamed module of loader net.fabricmc.loader.impl.launch.knot.KnotClassLoader @4d49af10)

crash-2023-03-26_10.08.08-client.txt

Thank you for looking at this and let me know if you need more info

Reproduction Steps

  1. why looking at the REI mixer recipe
  2. press ponder [w]
  3. "video" starts and runs about half way then client crash occurs ...

Expected Result

it not to crash? :)

Screenshots and Videos

sorry not setup for video

Crash Report or Log

https://github.com/Creators-of-Create/Create/files/11072027/crash-2023-03-26_10.08.08-client.txt

Operating System

windows 7

Mod Version

0.5.0i

Minecraft Version

1.19.2

Forge Version

fabric

Other Mods

AOF6 +

Additional Context

No response

AaronEspinosaGrc commented 1 year ago

I had the same error with another two items to ponder: Deployer and Millestone crash-2023-03-27_15.23.20-client.txt crash-2023-03-26_08.27.15-client.txt

AaronEspinosaGrc commented 1 year ago

In a way to isolate the problem, I only install Create Mod in Minecraft 1.19.2 and Forge 43.2.0 and no pondering got crashed. Tested on:

AaronEspinosaGrc commented 1 year ago

I found the possible reason of crash: The canary Mod. I installed it alongside the Create Mod and JEI (Just those mods are installed) on Forge 43.2.0 and Minecraft 1.19.2 and the crashed occurred on these machines:

crash-2023-03-26_08.27.15-client.txt crash-2023-03-26_08.23.38-client.txt

WebDragon commented 1 year ago

https://github.com/FTBTeam/FTB-Modpack-Issues/issues/3030 additional crash while pondering steam engine in FTB: One

Treeways commented 1 year ago

The same (or a very similar) issue happens with a handful of addon mods for create, such as ponder scenes from Little Logistics and Create Enchantment Industry. Sometimes the scenes will load and crash the game midway through, yet sometimes the scenes will simply crash right away when the scene is initially loaded (when you can see the floor).

However, this may have to do with one of the many other mods I have loaded. I'll investigate some more.

It seems like Canary has been causing some issues, yet I've also seen Ponder for KubeJS in the crash log, so that might be a result of mixins. So far, disabling both mods has not fixed the crashing issue for addons within my modpack. It is unclear why. This is false, I just tested again and it seems fine after a reboot.

Treeways commented 1 year ago

Canary however has proven to cause the same sort of crash. An update is pending on their side - see https://github.com/AbdElAziz333/Canary/issues/112

Aztiki commented 1 year ago

I've left a comment on another crash issue regarding pondering on here, I have a feeling it is something to do with Items, I think the thing all of these have in common is the fact that they have items in their pondering window. As I have the issue also whenever I use a mod that alters how items behave, e.g. Physics, shading changes, model changes, the droplight mod for example. This is an informed guess based on the testing and crashes I've experienced using both Canary and the Droplight mod

IThundxr commented 4 months ago

this is already fixed on fabric iirc, however if it still occurs open a needle issue on the fabric repo