Creators-of-Create / Create

[Forge Mod] Building Tools and Aesthetic Technology
MIT License
2.96k stars 912 forks source link

Bucket Duping #4701

Closed ClaudiusMinimus closed 1 month ago

ClaudiusMinimus commented 1 year ago

Describe the Bug

A player of my pack, Create on a Potato PC: Ultimate reported to me today a duping bug. I am not sure where the actual duping happens, but I think it might be the mixer. When he starts his dough factory, he adds one bucket. Very quickly there are many buckets until the system clogs and fails.

Reproduction Steps

  1. Load the attached dough_factory_2.nbt I had to zip it to upload. The schematic has signs pointing to important information to help reproduce the dupe bug.
  2. Using the screenshot shown below, make sure there is water in the pool, wheat in the vault, and all of the filters are set correctly as indicated by the signs.
  3. Turn on the factory after everything is set according to the instructions.

Expected Result

The buckets should not be duplicated

Screenshots and Videos

image image

Crash Report or Log

I have asked for the player to send me the log

Operating System

Linux Mint 20.3 locally, and Ubuntu server

Mod Version

0.5.0i

Minecraft Version

1.19.2

Forge Version

43.2.8

Other Mods

Create Potato Ultimate 1.19.2-4.6.1

AI Improvements(QueenOfMissiles) Angel Ring(DenisMasterHerobrine) AppleSkin(squeek502) Architectury API (Fabric/Forge)(shedaniel) AutoRegLib(Vazkii) Bad Wither No Cookie - Reloaded(Kreezxil) Balm (Forge Edition)(BlayTheNinth) Better Compatibility Checker(Gaz) BisectHosting Server Integration Menu FORGE Bookshelf(DarkhaxDev) Botania(Vazkii) Client Tweaks(BlayTheNinth) Cloth Config API (Fabric/Forge)(shedaniel) Clumps(Jaredlll08) Comforts (Fabric/Forge/Quilt)(TheIllusiveC4) Configured(MrCrayfish) Controlling(Jaredlll08) Crafting Slots(BlayTheNinth) Crafting Station(tfarecnim) Crafting Tweaks(BlayTheNinth) CraftPresence(CDAGaming) Crash Utilities(Darkere) Create Crafts & Additions(MRHminer) Create Deco(talrey) Create Jetpack(possible_triangle) Create Mechanical Extruder(oierbravo_mc) Create Sifting(oierbravo_mc) Create Slice & Dice(possible_triangle) Create Stuff & Additions(Furti_Two) Create(simibubi) Curios API (Forge)(TheIllusiveC4) Default Options(BlayTheNinth) Default World Type Forge Drippy Loading Screen Forge EasierVillagerTrading reForged(AbsolemJackdaw) Enchantment Descriptions(DarkhaxDev) Enhanced Mob Spawners(BR4NDER5) Extreme sound muffler (Forge)(LeoBeliik) FancyMenu Forge Farmer's Delight(vectorwing) FastFurnace(Shadows_of_Fire) FastWorkbench(Shadows_of_Fire) FerriteCore (Forge)(malte0811) FPS Reducer(bre2el) FTB Backups 2(FTB) FTB Chunks (Forge)(FTB) FTB Essentials (Forge)(FTB) FTB Library (Forge)(FTB) FTB Quests (Forge)(FTB) FTB Ranks (Forge)(FTB) FTB Teams (Forge)(FTB) Game Menu Mod Option Forge GraveStone Mod(henkelmax) Item Filters(LatvianModder) JCPlugin(PT400C) Just Enough Items (JEI)(mezz) Just Enough Resources (JER)(way2muchnoise) Konkrete Forge Kotlin for Forge(thedarkcolour) KubeJS(LatvianModder) Library Ferret - Forge(jtl_elisa) LibX(noeppinoeppi) Light Overlay (Rift/Forge/Fabric)(shedaniel) Lootr (Forge)(Noobanidus) Macaw's Windows(sketch_macaw) Magnesium/Rubidium Dynamic Lights(TeamDeusVult) Magnesium/Rubidium Extras(TeamDeusVult) Mouse Tweaks(YaLTeR) NetherPortalFix(BlayTheNinth) No Chat Reports(Aizistral) OCD Shaders(matt8297) Patchouli(Vazkii) Placebo(Shadows_of_Fire) PolyLib(Official_CreeperHost) Polymorph (Forge)(TheIllusiveC4) Powder Power FORGE Quark(Vazkii) Rapid Leaf Decay(GeheimagentNr1) Refined Storage Addons(raoulvdberge) Refined Storage(raoulvdberge) Repurposed Structures (Forge)(telepathicgrunt) Rhino(LatvianModder) RSInfinityBooster(hexeptiondev) Rubidium(Asek3) ShiftedLib(sajeyson12) ShulkerBoxTooltip Fabric/Forge Shutup Experimental Settings!(CorgiTaco) Silent Gear(SilentChaos512) Silent Lib (silentlib)(SilentChaos512) Sky GUIs(MelanX) Skyblock Builder(MelanX) Sophisticated Backpacks(P3pp3rF1y) Sophisticated Core(P3pp3rF1y) Spice of Life: Carrot Edition(lordcazsius) Squat Grow (Shift / Twerk to grow plants)(Gaz) Starlight (Forge)(Spottedstar) SwingThroughGrass(exidex) Tempad(CodexAdrian) The One Probe(McJty) Tom's Simple Storage Mod(tom54541) Torchmaster(xalcon) V-Tweaks(oitsjustjose) Wither Skeleton Tweaks(Shadows_of_Fire) Witherproofed(sajeyson12) Xaero's Minimap(xaero96) Xaero's World Map(xaero96)

Additional Context

No response

ClaudiusMinimus commented 1 year ago

Here is his latest.log as promised SameshimaPokishima_latest.log

Treeways commented 1 year ago

Any Automated Shapeless recipes that use water buckets instead of water liquids will dupe those buckets. (The dupe isn't completely free - it still costs the recipe's other ingredients.)

The same thing happens with any container - buckets, bottles, etc. - it always doubles it. For example, a mixing recipe that calls for 4 milk bottles (ie. from Neapolitan or Farmer's Delight) will output 8 empty bottles back.

With Tinkers Construct installed, this is effectively an Iron/Glass generation glitch. Even without it, it's basically free buckets with an automatic bread farm. It's been an urgent priority for me to patch this out of my modpack.

This glitch can be reproduced simply by crafting the following recipe from base Create:

create:crafting/appliances/dough image

^ Here I'm running a minimal mod setup on Create 0.5.0.i in 1.19.2.

This is an example of bottle duplication in my modpack, where one milk bottle will output two empty glass bottles:

image

(This is likely because of how bucket crafting works in vanilla, which preserves the bucket in the crafting grid. I'm not certain, but it's my gut feeling.)

Treeways commented 1 year ago

This also affects automated packing.

Here's an example using Upgrade Aquatic's Mulberry Jam. Since this recipe converts back to bottles with automated mixing, you could pipe this recipe between packing and mixing for an infinite bottle machine, or infinite glass with Tinkers enabled.

image image

Treeways commented 1 year ago

This is hopefully more of a temporary solution, but if anyone's interested in a KubeJS patch fix for 1.19.2 only, check out the KubeJS script I made to convert these recipes to liquid ones: https://gist.github.com/Treeway7/4025e1a4f4f22e4799a305e7280cb095

This was initially posted in a script showcase elsewhere, so here's the description I wrote there:


This is a KubeJS script that converts any specified automated fluid container recipes to use fluid recipes instead.

To convert recipes, use the provided function. See usage examples at the bottom of the script file.

1.19.2 only, sorry! Some functions used here don't exist in earlier versions of KubeJS.

Forge and Fabric is supported. The script is set to use Forge by default, but check lines 15-17 and lines 26-32 for instructions on how to set it to use Fabric.

Lots of work went into making this!

CelestialAbyss commented 1 year ago

Just wanted to pop in here and say that it seems to have been fixed in Create 0.5.1 when I tried it with the recipe for dough that uses a water bucket after hearing about the duping bug in a Discord vc.