Creators-of-Create / Create

[Forge Mod] Building Tools and Aesthetic Technology
MIT License
2.82k stars 889 forks source link

Duping with contraptions #4880

Closed Jakobuo closed 1 month ago

Jakobuo commented 1 year ago

Describe the Bug

When things such as dispensers or droppers pull from chests in moving contraptions, they seem to ignore NBT-data of stackable items. In combination with the toolbox, this allows for the duplication of any item.

Reproduction Steps

  1. Install Create
  2. Build a contraption that includes a chest and a dropper
  3. Put empty toolboxes in the chest
  4. Put a filled toolbox in the dropper
  5. Assemble the contraption and make it move.

Expected Result

Only one filled toolbox should be dropped.

Screenshots and Videos

https://youtu.be/uzlc98jgRqs

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.5.1b

Minecraft Version

1.19.2

Forge Version

43.2.12

Other Mods

None.

Additional Context

This issue is a consequence of issue #616. As far as I can tell, this only works with stackable items, since shulker boxes worked as expected.

Garwinium commented 1 year ago

image thanks it worked

Jakobuo commented 1 year ago

No problem

BumbleFuzzz commented 11 months ago

is this fixed yet? im hoping to make a bugless server

Jakobuo commented 11 months ago

Seeing how no one is assigned to this issue and there have been no mentions of it elsewhere or pull requests related to it, probably not.

BumbleFuzzz commented 11 months ago

not even in 0.5.1e?

BumbleFuzzz commented 11 months ago

@Jakobuo it seems to have been fixed

Jakobuo commented 11 months ago

I just tested it again, it still works for me with 0.5.1e.

Jakobuo commented 11 months ago

Also, the issue is still open, so it probably hasn't been fixed.

trqf commented 9 months ago

create 0.5.1f+neoforge47.1.79 server, it still works

BumbleFuzzz commented 7 months ago

@Jakobuo my appologies, i was on create fabric, I might not have replecated perfectly, but it might not work on fabric

Jakobuo commented 7 months ago

I haven't tested it on fabric myself, but in the mention above muriplz confirms that it also happens on fabric

hideki2k02 commented 3 months ago

Just to keep the issue on sight, the bug is still not fixed unfortunately

IThundxr commented 3 months ago

yes, the fix hasn't been released yet.