Creators-of-Create / Create

[Forge Mod] Building Tools and Aesthetic Technology
MIT License
2.81k stars 890 forks source link

Display error in Chinese language #5275

Closed QiMooz closed 1 month ago

QiMooz commented 1 year ago

Describe the Bug

When switching to Chinese, an error message is displayed after "kinetic Stress Capaticy" and "kinetic Stress Impact".

Reproduction Steps

1.Install MC and forge 2.Install "create" 3.Launching the game 4.Switch language to Chinese(简体中文)

Expected Result

No more error messages

Screenshots and Videos

1 3 2 4

Crash Report or Log

No response

Operating System

Windows 11

Mod Version

0.5.1d

Minecraft Version

1.20.1

Forge Version

47.1.43

Other Mods

No response

Additional Context

No response

drwoops commented 1 year ago

ok so the chinese lang file may have a mistake. you might want to propose an update to the chinese lang file on crowdin. see: https://github.com/Creators-of-Create/Create/tree/mc1.20.1/dev/src/main/resources/assets/create/lang

QiMooz commented 1 year ago

好的,所以中文语言文件可能有错误。您可能想在 Crowdin 上建议更新中文 lang 文件。请参阅:https://github.com/Creators-of-Create/Create/tree/mc1.20.1/dev/src/main/resources/assets/create/lang

Yes, I've already submitted translation requests for "kinetic Stress Capaticy" and "kinetic Stress Impact" to Chinese Simplified on "crowddin"!

Ironnoob73 commented 9 months ago

Looks like it's due to redundant characters “%1$s”, which were removed in 1.20:

assets\create\lang\en_us.json

...
  "create.tooltip.speedRequirement.slow": "Slow",
  "create.tooltip.stressImpact": "Kinetic Stress Impact:",
  "create.tooltip.stressImpact.high": "High",
...

assets\create\lang\zh_cn.json

...
  "create.tooltip.speedRequirement.slow": "慢",
  "create.tooltip.stressImpact": "应力影响:%1$s",
  "create.tooltip.stressImpact.high": "高",
...

But it's still in crowdin. image Looks like every other language has this issue.

IThundxr commented 1 month ago

Crowdin is community contributed, someone would need to go and fix the issues themselves https://crowdin.com/project/createmod